From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DATE_IN_PAST_12_24, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D9F5C433EF for ; Fri, 24 Sep 2021 12:03:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5B996103B for ; Fri, 24 Sep 2021 12:03:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E5B996103B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:46502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTjvA-0000vU-JW for qemu-devel@archiver.kernel.org; Fri, 24 Sep 2021 08:03:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTjrr-0006CJ-Ub for qemu-devel@nongnu.org; Fri, 24 Sep 2021 07:59:53 -0400 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:46632) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTjrq-0002av-2X for qemu-devel@nongnu.org; Fri, 24 Sep 2021 07:59:51 -0400 Received: by mail-qt1-x82f.google.com with SMTP id e16so9033957qte.13 for ; Fri, 24 Sep 2021 04:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=m02CTkaJvOt8vebGe9ytTOI1qXpjwEGR4Uir06EQOog=; b=XWUPaHjx6jnCUkgVGXQeJpBgwrYK4z8YxRyR3pzqn7vlFva4W3dKJgMGipDb+EWurB 3zj6Hon7VWcbQGQPyQyV4HLhni61WZcPCEUF+gFkCtZEYCeE79GqqWktrM50OxnkTCrF mkPViqSud6ysKse7cdAmK5SIJTSc7pPpc9ImPaWtBT74Vbo4+ujpdFgVBV+B08PHdiLq NmLesmwK9wqqwZ9FY7GXyhZHpXQT2bONLDRwC8WiZv1BYhirRMmDO0cngMiuJ9lSJD3J Ms3MntJBx6Debr/dWwu+9m45YryXS5zjWDCNe+4WEi3K6nOJaFkj+jARDAbscB1Nhsux 8iBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=m02CTkaJvOt8vebGe9ytTOI1qXpjwEGR4Uir06EQOog=; b=rY4PIl23nTPTZM6Db2oCw/OWkOgqO8fUpNxW/QZQBD3NYUu2FBowd/Vm/+yx4s5/Di V8nTTfIfStCLYvsI8TJiodS3Qr+s1E8hAWAyeIQROOXM8948Sf+B3AeQE55G8PgPoFjd NtTz5BvucyXYVuAcNvmYfKWU6koeNJeNeDWX190GKleIQDVUkKfnfnIYWaAJAZ/mPs/r ZPHvQKGckhFa1fncvVnPt0VVgl7nRx9yFcLDOqmM2g2dVuLEE0nutY/f9rY6tEDuZqnN fNMJBTPPqzEG31MlZFooabS54bqzrUVfcUTKYFQjtBpH54Y6+m4j+bugzGeGdTJIWHtv KVGw== X-Gm-Message-State: AOAM530F1XTrKxJjycDmfP0hm+m2SjLa4N406IJqo/jVAlnhgRjB/j/o q1uXwBqQ1XGtHNm3mZHT5/F15g== X-Google-Smtp-Source: ABdhPJzoIwBt/1JBLLQL+3Fu5ZxYSMw22Cmgpny7XzDz7eQBIaxPjITnbntUrCzZgoTvoNy5+p+FvQ== X-Received: by 2002:a05:622a:188d:: with SMTP id v13mr3646681qtc.294.1632484789097; Fri, 24 Sep 2021 04:59:49 -0700 (PDT) Received: from [192.168.3.43] (cpe-24-74-129-96.carolina.res.rr.com. [24.74.129.96]) by smtp.gmail.com with ESMTPSA id v23sm6035700qkj.76.2021.09.24.04.59.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Sep 2021 04:59:48 -0700 (PDT) Subject: Re: [PATCH v2 2/9] bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE To: Warner Losh , qemu-devel@nongnu.org References: <20210922045636.25206-1-imp@bsdimp.com> <20210922045636.25206-3-imp@bsdimp.com> From: Richard Henderson Message-ID: <261b4ee5-07d0-ac11-21a6-a5e1c4865fe1@linaro.org> Date: Thu, 23 Sep 2021 10:36:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210922045636.25206-3-imp@bsdimp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=richard.henderson@linaro.org; helo=mail-qt1-x82f.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_12_24=1.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kevans@freebsd.org, f4bug@amsat.org, =?UTF-8?Q?Mika=c3=abl_Urankar?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/21/21 9:56 PM, Warner Losh wrote: > From: Mikaël Urankar > > Simmilar to the equivalent linux-user: commit fb7e378cf9c, which added > checking to pread's return value. > > Signed-off-by: Mikaël Urankar > Signed-off-by: Warner Losh > --- > bsd-user/mmap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson > - pread(fd, g2h_untagged(start), end - start, offset); > + if (pread(fd, g2h_untagged(start), end - start, offset) == -1) > + return -1; If it's not too annoying wrt rebasing other cleanups, please add the braces now. r~