From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Andrew Jeffery <andrew@aj.id.au>,
Peter Maydell <peter.maydell@linaro.org>,
Alistair Francis <alistair@alistair23.me>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH 4/6] aspeed/smc: Rename 'max_peripherals' to 'max_cs'
Date: Mon, 7 Mar 2022 11:21:21 +0100 [thread overview]
Message-ID: <2623a97f-503e-8985-f1ba-e0315226aa42@gmail.com> (raw)
In-Reply-To: <20220307071856.1410731-5-clg@kaod.org>
On 7/3/22 08:18, Cédric Le Goater wrote:
> The naming makes more sense in a SPI controller model.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> include/hw/ssi/aspeed_smc.h | 2 +-
> hw/ssi/aspeed_smc.c | 42 ++++++++++++++++++-------------------
> 2 files changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/include/hw/ssi/aspeed_smc.h b/include/hw/ssi/aspeed_smc.h
> index 4a9354e13c7f..6501a04b8f3e 100644
> --- a/include/hw/ssi/aspeed_smc.h
> +++ b/include/hw/ssi/aspeed_smc.h
> @@ -95,7 +95,7 @@ struct AspeedSMCClass {
> uint8_t r_timings;
> uint8_t nregs_timings;
> uint8_t conf_enable_w0;
> - uint8_t max_peripherals;
> + uint8_t max_cs;
Can we use 'cs_num_max' or 'cs_count_max' instead?
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2022-03-07 11:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 7:18 [PATCH 0/6] aspeed/smc: 'num_cs' cleanup Cédric Le Goater
2022-03-07 7:18 ` [PATCH 1/6] aspeed/smc: Use max number of CE instead of 'num_cs' Cédric Le Goater
2022-03-07 10:19 ` Philippe Mathieu-Daudé
2022-03-07 11:03 ` Alistair Francis
2022-03-07 7:18 ` [PATCH 2/6] aspeed: Rework aspeed_board_init_flashes() interface Cédric Le Goater
2022-03-07 10:21 ` Philippe Mathieu-Daudé
2022-03-07 20:51 ` Alistair Francis
2022-03-07 7:18 ` [PATCH 3/6] aspeed/smc: Remove 'num_cs' field Cédric Le Goater
2022-03-07 10:22 ` Philippe Mathieu-Daudé
2022-03-07 11:05 ` Alistair Francis
2022-03-07 7:18 ` [PATCH 4/6] aspeed/smc: Rename 'max_peripherals' to 'max_cs' Cédric Le Goater
2022-03-07 10:21 ` Philippe Mathieu-Daudé [this message]
2022-03-07 11:07 ` Alistair Francis
2022-03-07 7:18 ` [PATCH 5/6] aspeed/smc: Let the SSI core layer define the bus name Cédric Le Goater
2022-03-07 10:25 ` Philippe Mathieu-Daudé
2022-03-07 10:36 ` Cédric Le Goater
2022-03-08 6:41 ` Alistair Francis
2022-03-07 7:18 ` [PATCH 6/6] aspeed/smc: Fix error log Cédric Le Goater
2022-03-07 10:23 ` Philippe Mathieu-Daudé
2022-03-07 11:01 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2623a97f-503e-8985-f1ba-e0315226aa42@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=alistair@alistair23.me \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).