qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Subject: Re: [RFC PATCH v3 37/44] target/loongarch: Implement vbitsel vset
Date: Mon, 24 Apr 2023 16:53:11 +0100	[thread overview]
Message-ID: <26340d13-cd38-03eb-7306-abbbc1fbd794@linaro.org> (raw)
In-Reply-To: <20230420080709.3352575-38-gaosong@loongson.cn>

On 4/20/23 09:07, Song Gao wrote:
> +#define SETANYEQZ(NAME, MO)                                         \
> +void HELPER(NAME)(CPULoongArchState *env, uint32_t cd, uint32_t vj) \
> +{                                                                   \
> +    bool ret = false;                                               \
> +    VReg *Vj = &(env->fpr[vj].vreg);                                \
> +                                                                    \
> +    ret = do_match2(0, Vj->D(0), Vj->D(1), MO);                     \
> +    env->cf[cd & 0x7] = ret;                                        \
> +}

Good.

> +
> +#define SETALLNEZ(NAME, BIT, E)                                     \
> +void HELPER(NAME)(CPULoongArchState *env, uint32_t cd, uint32_t vj) \
> +{                                                                   \
> +    int i;                                                          \
> +    bool ret = true;                                                \
> +    VReg *Vj = &(env->fpr[vj].vreg);                                \
> +                                                                    \
> +    for (i = 0; i < LSX_LEN/BIT; i++) {                             \
> +        ret &= (Vj->E(i) != 0);                                     \
> +    }                                                               \
> +    env->cf[cd & 0x7] = ret;                                        \
> +}

setallnez = !setanyeqz, so use !do_match2().



r~


  reply	other threads:[~2023-04-24 15:53 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20  8:06 [RFC PATCH v3 00/44] Add LoongArch LSX instructions Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 01/44] target/loongarch: Add LSX data type VReg Song Gao
2023-04-23 19:41   ` Richard Henderson
2023-04-24 11:14     ` Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 02/44] target/loongarch: meson.build support build LSX Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 03/44] target/loongarch: Add CHECK_SXE maccro for check LSX enable Song Gao
2023-04-24  5:48   ` Richard Henderson
2023-04-20  8:06 ` [RFC PATCH v3 04/44] target/loongarch: Implement vadd/vsub Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 05/44] target/loongarch: Implement vaddi/vsubi Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 06/44] target/loongarch: Implement vneg Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 07/44] target/loongarch: Implement vsadd/vssub Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 08/44] target/loongarch: Implement vhaddw/vhsubw Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 09/44] target/loongarch: Implement vaddw/vsubw Song Gao
2023-04-24  6:23   ` Richard Henderson
2023-04-20  8:06 ` [RFC PATCH v3 10/44] target/loongarch: Implement vavg/vavgr Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 11/44] target/loongarch: Implement vabsd Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 12/44] target/loongarch: Implement vadda Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 13/44] target/loongarch: Implement vmax/vmin Song Gao
2023-04-24  7:11   ` Richard Henderson
2023-04-20  8:06 ` [RFC PATCH v3 14/44] target/loongarch: Implement vmul/vmuh/vmulw{ev/od} Song Gao
2023-04-24  7:15   ` Richard Henderson
2023-04-24 11:25     ` Song Gao
2023-04-24 12:44       ` Richard Henderson
2023-04-24 13:00         ` Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 15/44] target/loongarch: Implement vmadd/vmsub/vmaddw{ev/od} Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 16/44] target/loongarch: Implement vdiv/vmod Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 17/44] target/loongarch: Implement vsat Song Gao
2023-04-24 15:10   ` Richard Henderson
2023-04-20  8:06 ` [RFC PATCH v3 18/44] target/loongarch: Implement vexth Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 19/44] target/loongarch: Implement vsigncov Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 20/44] target/loongarch: Implement vmskltz/vmskgez/vmsknz Song Gao
2023-04-24 15:13   ` Richard Henderson
2023-04-20  8:06 ` [RFC PATCH v3 21/44] target/loongarch: Implement LSX logic instructions Song Gao
2023-04-24 15:23   ` Richard Henderson
2023-04-20  8:06 ` [RFC PATCH v3 22/44] target/loongarch: Implement vsll vsrl vsra vrotr Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 23/44] target/loongarch: Implement vsllwil vextl Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 24/44] target/loongarch: Implement vsrlr vsrar Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 25/44] target/loongarch: Implement vsrln vsran Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 26/44] target/loongarch: Implement vsrlrn vsrarn Song Gao
2023-04-24 15:26   ` Richard Henderson
2023-04-20  8:06 ` [RFC PATCH v3 27/44] target/loongarch: Implement vssrln vssran Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 28/44] target/loongarch: Implement vssrlrn vssrarn Song Gao
2023-04-24 15:28   ` Richard Henderson
2023-04-20  8:06 ` [RFC PATCH v3 29/44] target/loongarch: Implement vclo vclz Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 30/44] target/loongarch: Implement vpcnt Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 31/44] target/loongarch: Implement vbitclr vbitset vbitrev Song Gao
2023-04-24 15:37   ` Richard Henderson
2023-04-20  8:06 ` [RFC PATCH v3 32/44] target/loongarch: Implement vfrstp Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 33/44] target/loongarch: Implement LSX fpu arith instructions Song Gao
2023-04-20  8:06 ` [RFC PATCH v3 34/44] target/loongarch: Implement LSX fpu fcvt instructions Song Gao
2023-04-20  8:07 ` [RFC PATCH v3 35/44] target/loongarch: Implement vseq vsle vslt Song Gao
2023-04-24 15:49   ` Richard Henderson
2023-04-20  8:07 ` [RFC PATCH v3 36/44] target/loongarch: Implement vfcmp Song Gao
2023-04-20  8:07 ` [RFC PATCH v3 37/44] target/loongarch: Implement vbitsel vset Song Gao
2023-04-24 15:53   ` Richard Henderson [this message]
2023-04-20  8:07 ` [RFC PATCH v3 38/44] target/loongarch: Implement vinsgr2vr vpickve2gr vreplgr2vr Song Gao
2023-04-20  8:07 ` [RFC PATCH v3 39/44] target/loongarch: Implement vreplve vpack vpick Song Gao
2023-04-20  8:07 ` [RFC PATCH v3 40/44] target/loongarch: Implement vilvl vilvh vextrins vshuf Song Gao
2023-04-24 15:54   ` Richard Henderson
2023-04-20  8:07 ` [RFC PATCH v3 41/44] target/loongarch: Implement vld vst Song Gao
2023-04-24 16:01   ` Richard Henderson
2023-04-20  8:07 ` [RFC PATCH v3 42/44] target/loongarch: Implement vldi Song Gao
2023-04-24 16:02   ` Richard Henderson
2023-04-20  8:07 ` [RFC PATCH v3 43/44] target/loongarch: Use {set/get}_gpr replace to cpu_fpr Song Gao
2023-04-24 16:02   ` Richard Henderson
2023-04-20  8:07 ` [RFC PATCH v3 44/44] target/loongarch: CPUCFG support LSX Song Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26340d13-cd38-03eb-7306-abbbc1fbd794@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=gaosong@loongson.cn \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).