From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44145)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bXNeM-00085T-E1
	for qemu-devel@nongnu.org; Wed, 10 Aug 2016 03:10:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bXNeJ-0003fs-4W
	for qemu-devel@nongnu.org; Wed, 10 Aug 2016 03:10:02 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:48199)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bXNeI-0003fQ-Se
	for qemu-devel@nongnu.org; Wed, 10 Aug 2016 03:09:59 -0400
Date: Wed, 10 Aug 2016 03:09:57 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <264286456.771001.1470812997473.JavaMail.zimbra@redhat.com>
In-Reply-To: <20160810021544.GH11351@al.usersys.redhat.com>
References: <1470387870-30438-1-git-send-email-famz@redhat.com>
	<1470387870-30438-3-git-send-email-famz@redhat.com>
	<66317136-7ead-e3ba-ad3b-e295ced14164@redhat.com>
	<20160810021544.GH11351@al.usersys.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 2/2] docker: Add "--enable-werror" to
 configure command line
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>


> On Tue, 08/09 17:21, Paolo Bonzini wrote:
> > On 05/08/2016 11:04, Fam Zheng wrote:
> > > We don't have .git in the docker checkout, add this to enable -Werror
> > > explicitly.
> > > 
> > > Signed-off-by: Fam Zheng <famz@redhat.com>
> > > Message-id: 1469453510-658-1-git-send-email-famz@redhat.com
> > > ---
> > >  tests/docker/common.rc | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> > > index 77069e1..0c6d8d5 100755
> > > --- a/tests/docker/common.rc
> > > +++ b/tests/docker/common.rc
> > > @@ -24,6 +24,7 @@ requires()
> > >  build_qemu()
> > >  {
> > >      $QEMU_SRC/configure \
> > > +        --enable-werror \
> > >          ${TARGET_LIST:+"--target-list=${TARGET_LIST}"} \
> > >          --prefix="$PWD/install" \
> > >          $EXTRA_CONFIGURE_OPTS \
> > > 
> > 
> > centos6 has -Wuninitialized errors.  Should this be applied only to
> > Fedora and Ubuntu?
> 
> That way I think build_qemu can be made sensible to the env. For now I'm not
> seeing any compiling failure with centos6, even though this patch is already
> merged.  Do you mean this is a potential false alarm?

I don't know... I remember seeing some, but now I don't see any failure.
Perhaps this is because of --enable-debug?  Uninitialized variables require
optimization.  But CentOS 6 should have _FORTIFY_SOURCE and thus should
enable optimization.

Paolo