From: Richard Henderson <richard.henderson@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Cc: maobibo@loongson.cn
Subject: Re: [PATCH v6 51/57] target/loongarch: Implement xvinsgr2vr xvpickve2gr
Date: Wed, 13 Sep 2023 20:02:43 -0700 [thread overview]
Message-ID: <2643cbdb-e73e-644a-3052-5a1867434b5b@linaro.org> (raw)
In-Reply-To: <20230914022645.1151356-52-gaosong@loongson.cn>
On 9/13/23 19:26, Song Gao wrote:
> +static inline int vec_reg_offset(int regno, int index, MemOp mop)
> +{
> + const uint8_t size = 1 << mop;
> + int offs = index * size;
> +
> +#if HOST_BIG_ENDIAN
> + if (size < 8 ) {
> + offs ^ = (8 - size);
> + }
> +#endif
> + return offs + vec_full_offset(regno);
> +}
Merge the #if into the if:
if (HOST_BIG_ENDIAN && size < 8)
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-09-14 3:03 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 2:25 [PATCH v6 00/57] Add LoongArch LASX instructions Song Gao
2023-09-14 2:25 ` [PATCH v6 01/57] target/loongarch: Renamed lsx*.c to vec* .c Song Gao
2023-09-14 2:25 ` [PATCH v6 02/57] target/loongarch: Implement gvec_*_vl functions Song Gao
2023-09-14 2:25 ` [PATCH v6 03/57] target/loongarch: Use gen_helper_gvec_4_ptr for 4OP + env vector instructions Song Gao
2023-09-14 2:25 ` [PATCH v6 04/57] target/loongarch: Use gen_helper_gvec_4 for 4OP " Song Gao
2023-09-14 2:25 ` [PATCH v6 05/57] target/loongarch: Use gen_helper_gvec_3_ptr for 3OP + env " Song Gao
2023-09-14 2:25 ` [PATCH v6 06/57] target/loongarch: Use gen_helper_gvec_3 for 3OP " Song Gao
2023-09-14 2:54 ` Richard Henderson
2023-09-14 2:25 ` [PATCH v6 07/57] target/loongarch: Use gen_helper_gvec_2_ptr for 2OP + env " Song Gao
2023-09-14 2:25 ` [PATCH v6 08/57] target/loongarch: Use gen_helper_gvec_2 for 2OP " Song Gao
2023-09-14 2:25 ` [PATCH v6 09/57] target/loongarch: Use gen_helper_gvec_2i for 2OP + imm " Song Gao
2023-09-14 2:25 ` [PATCH v6 10/57] target/loongarch: Replace CHECK_SXE to check_vec(ctx, 16) Song Gao
2023-09-14 2:25 ` [PATCH v6 11/57] target/loongarch: Add LASX data support Song Gao
2023-09-14 2:26 ` [PATCH v6 12/57] target/loongarch: check_vec support check LASX instructions Song Gao
2023-09-14 2:26 ` [PATCH v6 13/57] target/loongarch: Add avail_LASX to " Song Gao
2023-09-14 2:26 ` [PATCH v6 14/57] target/loongarch: Implement xvadd/xvsub Song Gao
2023-09-14 2:26 ` [PATCH v6 15/57] target/loongarch: Implement xvreplgr2vr Song Gao
2023-09-14 2:26 ` [PATCH v6 16/57] target/loongarch: Implement xvaddi/xvsubi Song Gao
2023-09-14 2:26 ` [PATCH v6 17/57] target/loongarch: Implement xvneg Song Gao
2023-09-14 2:26 ` [PATCH v6 18/57] target/loongarch: Implement xvsadd/xvssub Song Gao
2023-09-14 2:26 ` [PATCH v6 19/57] target/loongarch: Implement xvhaddw/xvhsubw Song Gao
2023-09-14 2:26 ` [PATCH v6 20/57] target/loongarch: Implement xvaddw/xvsubw Song Gao
2023-09-14 2:26 ` [PATCH v6 21/57] target/loongarch: Implement xavg/xvagr Song Gao
2023-09-14 2:26 ` [PATCH v6 22/57] target/loongarch: Implement xvabsd Song Gao
2023-09-14 2:26 ` [PATCH v6 23/57] target/loongarch: Implement xvadda Song Gao
2023-09-14 2:26 ` [PATCH v6 24/57] target/loongarch: Implement xvmax/xvmin Song Gao
2023-09-14 2:26 ` [PATCH v6 25/57] target/loongarch: Implement xvmul/xvmuh/xvmulw{ev/od} Song Gao
2023-09-14 2:26 ` [PATCH v6 26/57] target/loongarch: Implement xvmadd/xvmsub/xvmaddw{ev/od} Song Gao
2023-09-14 2:26 ` [PATCH v6 27/57] target/loongarch; Implement xvdiv/xvmod Song Gao
2023-09-14 2:26 ` [PATCH v6 28/57] target/loongarch: Implement xvsat Song Gao
2023-09-14 2:26 ` [PATCH v6 29/57] target/loongarch: Implement xvexth Song Gao
2023-09-14 2:26 ` [PATCH v6 30/57] target/loongarch: Implement vext2xv Song Gao
2023-09-14 2:26 ` [PATCH v6 31/57] target/loongarch: Implement xvsigncov Song Gao
2023-09-14 2:26 ` [PATCH v6 32/57] target/loongarch: Implement xvmskltz/xvmskgez/xvmsknz Song Gao
2023-09-14 2:26 ` [PATCH v6 33/57] target/loognarch: Implement xvldi Song Gao
2023-09-14 2:26 ` [PATCH v6 34/57] target/loongarch: Implement LASX logic instructions Song Gao
2023-09-14 2:26 ` [PATCH v6 35/57] target/loongarch: Implement xvsll xvsrl xvsra xvrotr Song Gao
2023-09-14 2:26 ` [PATCH v6 36/57] target/loongarch: Implement xvsllwil xvextl Song Gao
2023-09-14 2:26 ` [PATCH v6 37/57] target/loongarch: Implement xvsrlr xvsrar Song Gao
2023-09-14 2:26 ` [PATCH v6 38/57] target/loongarch: Implement xvsrln xvsran Song Gao
2023-09-14 2:26 ` [PATCH v6 39/57] target/loongarch: Implement xvsrlrn xvsrarn Song Gao
2023-09-14 2:26 ` [PATCH v6 40/57] target/loongarch: Implement xvssrln xvssran Song Gao
2023-09-14 2:26 ` [PATCH v6 41/57] target/loongarch: Implement xvssrlrn xvssrarn Song Gao
2023-09-14 2:26 ` [PATCH v6 42/57] target/loongarch: Implement xvclo xvclz Song Gao
2023-09-14 2:26 ` [PATCH v6 43/57] target/loongarch: Implement xvpcnt Song Gao
2023-09-14 2:26 ` [PATCH v6 44/57] target/loongarch: Implement xvbitclr xvbitset xvbitrev Song Gao
2023-09-14 2:26 ` [PATCH v6 45/57] target/loongarch: Implement xvfrstp Song Gao
2023-09-14 2:26 ` [PATCH v6 46/57] target/loongarch: Implement LASX fpu arith instructions Song Gao
2023-09-14 2:26 ` [PATCH v6 47/57] target/loongarch: Implement LASX fpu fcvt instructions Song Gao
2023-09-14 2:26 ` [PATCH v6 48/57] target/loongarch: Implement xvseq xvsle xvslt Song Gao
2023-09-14 2:26 ` [PATCH v6 49/57] target/loongarch: Implement xvfcmp Song Gao
2023-09-14 2:26 ` [PATCH v6 50/57] target/loongarch: Implement xvbitsel xvset Song Gao
2023-09-14 2:26 ` [PATCH v6 51/57] target/loongarch: Implement xvinsgr2vr xvpickve2gr Song Gao
2023-09-14 3:02 ` Richard Henderson [this message]
2023-09-14 8:25 ` gaosong
2023-09-14 2:26 ` [PATCH v6 52/57] target/loongarch: Implement xvreplve xvinsve0 xvpickve Song Gao
2023-09-14 3:16 ` Richard Henderson
2023-09-14 8:24 ` gaosong
2023-09-14 2:26 ` [PATCH v6 53/57] target/loongarch: Implement xvpack xvpick xvilv{l/h} Song Gao
2023-09-14 2:26 ` [PATCH v6 54/57] target/loongarch: Implement xvshuf xvperm{i} xvshuf4i Song Gao
2023-09-16 7:55 ` gaosong
2023-09-16 14:05 ` Richard Henderson
2023-09-14 2:26 ` [PATCH v6 55/57] target/loongarch: Implement xvld xvst Song Gao
2023-09-14 2:26 ` [PATCH v6 56/57] target/loongarch: Move simply DO_XX marcos togther Song Gao
2023-09-14 2:26 ` [PATCH v6 57/57] target/loongarch: CPUCFG support LASX Song Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2643cbdb-e73e-644a-3052-5a1867434b5b@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gaosong@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).