From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IWvmQ-0001uB-Cf for qemu-devel@nongnu.org; Sun, 16 Sep 2007 11:11:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IWvmO-0001tR-Oe for qemu-devel@nongnu.org; Sun, 16 Sep 2007 11:11:26 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IWvmO-0001tO-Lj for qemu-devel@nongnu.org; Sun, 16 Sep 2007 11:11:24 -0400 Received: from eastrmmtao105.cox.net ([68.230.240.47]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IWvmO-0006vG-9p for qemu-devel@nongnu.org; Sun, 16 Sep 2007 11:11:24 -0400 Message-ID: <26700091.1189955481400.JavaMail.root@eastrmwml11> Date: Sun, 16 Sep 2007 11:11:21 -0400 From: Ben Taylor Subject: Re: [Qemu-devel] Comment for Solaris fix for the HPTC MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Reply-To: sol10x86@cox.net, qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Johannes Schindelin Cc: qemu-devel@nongnu.org ---- Johannes Schindelin wrote: > Hi Ben, > > On Sat, 15 Sep 2007, Ben Taylor wrote: > > > +#ifdef __sun__ > > +/* Have to define this for Solaris as ULONG_LONG_MAX is not defined > > + anywhere. ULONG_MAX is correct only on _LP64 systems */ > > +#define ULONG_LONG_MAX 18446744073709551615UL > > +#endif > > + > > These constants are always defined, right? So why not "#ifndef > ULONG_LONG_MAX"? I fear I may not have explained this well. On the Solaris systems I have access to, I find no system include file that defines "ULONG_LONG_MAX". There are defines for ULONG_MAX which is equivilent to the value that ULONG_LONG_MAX is, but only when the system is being compiled on an "_LP64" (ie x86_64) system. When the system is 32-bit, ULONG_MAX defaults to a typical max value for a 32-bit unsigned int. That help? Ben