From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Igor Mammedov <imammedo@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Shiju Jose <shiju.jose@huawei.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Gavin Shan <gshan@redhat.com>, Ani Sinha <anisinha@redhat.com>,
Dongjiu Geng <gengdongjiu1@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 04/20] Revert "hw/acpi/ghes: Make ghes_record_cper_errors() static"
Date: Fri, 7 Mar 2025 22:02:56 +0100 [thread overview]
Message-ID: <26709015-6fac-48c4-80a2-cc6a4150d3a4@linaro.org> (raw)
In-Reply-To: <9cb6c734f32f01206db562b9a406829bf81e19d9.1741374594.git.mchehab+huawei@kernel.org>
On 7/3/25 20:14, Mauro Carvalho Chehab wrote:
> The ghes_record_cper_errors() function was introduced to be used
> by other types of errors, as part of the error injection
> patch series. That's why it is not static.
>
> Make it non-static again to allow its usage outside ghes.c
>
> This reverts commit 611f3bdb20f7828b0813aa90d47d1275ef18329b.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> hw/acpi/ghes.c | 6 ++++--
> include/hw/acpi/ghes.h | 2 ++
> 2 files changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
And I apologize for missing to relate the 2 previous series.
next prev parent reply other threads:[~2025-03-07 21:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 19:14 [PATCH v8 00/20] Change ghes to use HEST-based offsets and add support for error inject Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 01/20] tests/acpi: virt: add an empty HEST file Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 02/20] tests/qtest/bios-tables-test: extend to also check HEST table Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 03/20] tests/acpi: virt: update HEST file with its current data Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 04/20] Revert "hw/acpi/ghes: Make ghes_record_cper_errors() static" Mauro Carvalho Chehab
2025-03-07 21:02 ` Philippe Mathieu-Daudé [this message]
2025-03-07 19:14 ` [PATCH v8 05/20] acpi/ghes: Cleanup the code which gets ghes ged state Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 06/20] acpi/ghes: prepare to change the way HEST offsets are calculated Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 07/20] acpi/ghes: add a firmware file with HEST address Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 08/20] acpi/ghes: Use HEST table offsets when preparing GHES records Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 09/20] acpi/ghes: don't hard-code the number of sources for HEST table Mauro Carvalho Chehab
2025-05-12 19:42 ` Michael S. Tsirkin
2025-05-20 6:47 ` Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 10/20] acpi/ghes: add a notifier to notify when error data is ready Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 11/20] acpi/generic_event_device: Update GHES migration to cover hest addr Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 12/20] acpi/generic_event_device: add logic to detect if HEST addr is available Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 13/20] acpi/generic_event_device: add an APEI error device Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 14/20] tests/acpi: virt: allow acpi table changes at DSDT and HEST tables Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 15/20] arm/virt: Wire up a GED error device for ACPI / GHES Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 16/20] qapi/acpi-hest: add an interface to do generic CPER error injection Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 17/20] acpi/generic_event_device.c: enable use_hest_addr for QEMU 10.x Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 18/20] tests/acpi: virt: update HEST and DSDT tables Mauro Carvalho Chehab
2025-03-07 21:04 ` Philippe Mathieu-Daudé
2025-03-07 19:14 ` [PATCH v8 19/20] docs: hest: add new "etc/acpi_table_hest_addr" and update workflow Mauro Carvalho Chehab
2025-03-07 19:14 ` [PATCH v8 20/20] scripts/ghes_inject: add a script to generate GHES error inject Mauro Carvalho Chehab
2025-03-07 21:05 ` Philippe Mathieu-Daudé
2025-03-08 9:22 ` Mauro Carvalho Chehab
2025-03-25 1:55 ` [PATCH v8 00/20] Change ghes to use HEST-based offsets and add support for " Mauro Carvalho Chehab
2025-05-11 13:44 ` Michael S. Tsirkin
2025-05-11 13:45 ` Michael S. Tsirkin
2025-05-20 6:48 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26709015-6fac-48c4-80a2-cc6a4150d3a4@linaro.org \
--to=philmd@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=anisinha@redhat.com \
--cc=gengdongjiu1@gmail.com \
--cc=gshan@redhat.com \
--cc=imammedo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mst@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shiju.jose@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).