From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: quintela@redhat.com, Denis Plotnikov <dplotnikov@virtuozzo.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [PATCH] configure: change a typo in zstd config
Date: Wed, 4 Mar 2020 20:05:33 +0100 [thread overview]
Message-ID: <26715e80-32fa-5ebf-9f3b-c110f6c9b7fa@redhat.com> (raw)
In-Reply-To: <878skhvbq0.fsf@secure.laptop>
On 3/3/20 1:56 PM, Juan Quintela wrote:
> Denis Plotnikov <dplotnikov@virtuozzo.com> wrote:
>> Package manager --exist flag is used instead of --exists.
>> Fix it.
>>
>> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> queued.
It doesn't seem that trivial:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg684754.html
>
> thanks.
>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 7b373bc0bb..caa65f5883 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2464,7 +2464,7 @@ fi
>> # zstd check
>>
>> if test "$zstd" != "no" ; then
>> - if $pkg_config --exist libzstd ; then
>> + if $pkg_config --exists libzstd ; then
>> zstd_cflags="$($pkg_config --cflags libzstd)"
>> zstd_libs="$($pkg_config --libs libzstd)"
>> LIBS="$zstd_libs $LIBS"
>
>
next prev parent reply other threads:[~2020-03-04 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 12:49 [PATCH] configure: change a typo in zstd config Denis Plotnikov
2020-03-03 12:56 ` Juan Quintela
2020-03-04 19:05 ` Philippe Mathieu-Daudé [this message]
2020-03-05 9:31 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26715e80-32fa-5ebf-9f3b-c110f6c9b7fa@redhat.com \
--to=philmd@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dplotnikov@virtuozzo.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).