* [PATCH] configure: change a typo in zstd config
@ 2020-03-03 12:49 Denis Plotnikov
2020-03-03 12:56 ` Juan Quintela
0 siblings, 1 reply; 4+ messages in thread
From: Denis Plotnikov @ 2020-03-03 12:49 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, dgilbert, quintela
Package manager --exist flag is used instead of --exists.
Fix it.
Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 7b373bc0bb..caa65f5883 100755
--- a/configure
+++ b/configure
@@ -2464,7 +2464,7 @@ fi
# zstd check
if test "$zstd" != "no" ; then
- if $pkg_config --exist libzstd ; then
+ if $pkg_config --exists libzstd ; then
zstd_cflags="$($pkg_config --cflags libzstd)"
zstd_libs="$($pkg_config --libs libzstd)"
LIBS="$zstd_libs $LIBS"
--
2.17.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] configure: change a typo in zstd config
2020-03-03 12:49 [PATCH] configure: change a typo in zstd config Denis Plotnikov
@ 2020-03-03 12:56 ` Juan Quintela
2020-03-04 19:05 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Juan Quintela @ 2020-03-03 12:56 UTC (permalink / raw)
To: Denis Plotnikov; +Cc: peter.maydell, qemu-devel, dgilbert
Denis Plotnikov <dplotnikov@virtuozzo.com> wrote:
> Package manager --exist flag is used instead of --exists.
> Fix it.
>
> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued.
thanks.
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 7b373bc0bb..caa65f5883 100755
> --- a/configure
> +++ b/configure
> @@ -2464,7 +2464,7 @@ fi
> # zstd check
>
> if test "$zstd" != "no" ; then
> - if $pkg_config --exist libzstd ; then
> + if $pkg_config --exists libzstd ; then
> zstd_cflags="$($pkg_config --cflags libzstd)"
> zstd_libs="$($pkg_config --libs libzstd)"
> LIBS="$zstd_libs $LIBS"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] configure: change a typo in zstd config
2020-03-03 12:56 ` Juan Quintela
@ 2020-03-04 19:05 ` Philippe Mathieu-Daudé
2020-03-05 9:31 ` Juan Quintela
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-04 19:05 UTC (permalink / raw)
To: quintela, Denis Plotnikov; +Cc: peter.maydell, qemu-devel, dgilbert
On 3/3/20 1:56 PM, Juan Quintela wrote:
> Denis Plotnikov <dplotnikov@virtuozzo.com> wrote:
>> Package manager --exist flag is used instead of --exists.
>> Fix it.
>>
>> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> queued.
It doesn't seem that trivial:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg684754.html
>
> thanks.
>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 7b373bc0bb..caa65f5883 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2464,7 +2464,7 @@ fi
>> # zstd check
>>
>> if test "$zstd" != "no" ; then
>> - if $pkg_config --exist libzstd ; then
>> + if $pkg_config --exists libzstd ; then
>> zstd_cflags="$($pkg_config --cflags libzstd)"
>> zstd_libs="$($pkg_config --libs libzstd)"
>> LIBS="$zstd_libs $LIBS"
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] configure: change a typo in zstd config
2020-03-04 19:05 ` Philippe Mathieu-Daudé
@ 2020-03-05 9:31 ` Juan Quintela
0 siblings, 0 replies; 4+ messages in thread
From: Juan Quintela @ 2020-03-05 9:31 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: peter.maydell, Denis Plotnikov, qemu-devel, dgilbert
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> On 3/3/20 1:56 PM, Juan Quintela wrote:
>> Denis Plotnikov <dplotnikov@virtuozzo.com> wrote:
>>> Package manager --exist flag is used instead of --exists.
>>> Fix it.
>>>
>>> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
>>
>> Reviewed-by: Juan Quintela <quintela@redhat.com>
>>
>> queued.
>
> It doesn't seem that trivial:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg684754.html
I think you need to do a make clean.
And I found why I didn't catch that problem. Fedora pkg-config is soooo
intelligent:
$ pkg-config --exist libzstd; echo $?
0
$ pkg-config --exists libzstd; echo $?
0
$ pkg-config --exists libzstd33; echo $?
1
$ pkg-config --exist libzstd33; echo $?
1
$
I tried with libzstd-devel installed and uninstalled, with --enable-zstd
and --disable-zstd, and it always did the right thing for me.
Later, Juan.
>
>>
>> thanks.
>>
>>> ---
>>> configure | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 7b373bc0bb..caa65f5883 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2464,7 +2464,7 @@ fi
>>> # zstd check
>>> if test "$zstd" != "no" ; then
>>> - if $pkg_config --exist libzstd ; then
>>> + if $pkg_config --exists libzstd ; then
>>> zstd_cflags="$($pkg_config --cflags libzstd)"
>>> zstd_libs="$($pkg_config --libs libzstd)"
>>> LIBS="$zstd_libs $LIBS"
>>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-05 9:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-03 12:49 [PATCH] configure: change a typo in zstd config Denis Plotnikov
2020-03-03 12:56 ` Juan Quintela
2020-03-04 19:05 ` Philippe Mathieu-Daudé
2020-03-05 9:31 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).