From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, Greg Kurz <groug@kaod.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 2/2] target/ppc: Use tcg_constant_i64() in gen_brh()
Date: Sun, 3 Oct 2021 11:22:26 -0400 [thread overview]
Message-ID: <2691b37b-ff39-4321-fd3c-d3e9fd185a6a@linaro.org> (raw)
In-Reply-To: <20211003141711.3673181-3-f4bug@amsat.org>
On 10/3/21 10:17 AM, Philippe Mathieu-Daudé wrote:
> The mask of the Byte-Reverse Halfword opcode is a read-only
> constant. We can avoid using a TCG temporary by moving the
> mask to the constant pool.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> target/ppc/translate.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2021-10-03 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 14:17 [PATCH 0/2] target/ppc: Use tcg_constant_* Philippe Mathieu-Daudé
2021-10-03 14:17 ` [PATCH 1/2] target/ppc: Use tcg_constant_i32() in gen_setb() Philippe Mathieu-Daudé
2021-10-03 15:21 ` Richard Henderson
2021-10-05 0:46 ` David Gibson
2021-10-03 14:17 ` [PATCH 2/2] target/ppc: Use tcg_constant_i64() in gen_brh() Philippe Mathieu-Daudé
2021-10-03 15:22 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2691b37b-ff39-4321-fd3c-d3e9fd185a6a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).