qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: Re: [PATCH for-8.1] tests/tcg: Disable filename test for info proc mappings
Date: Wed, 09 Aug 2023 12:59:32 +0200	[thread overview]
Message-ID: <26b47e37f11835201784dae30cebdd03b87ebdf4.camel@linux.ibm.com> (raw)
In-Reply-To: <20230808234958.148910-1-richard.henderson@linaro.org>

On Tue, 2023-08-08 at 16:49 -0700, Richard Henderson wrote:
> This test fails when host page size != guest page size,
> because qemu may not be able to directly map the file.
> 
> Fixes: a6341482695 ("tests/tcg: Add a test for info proc mappings")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tests/tcg/multiarch/gdbstub/test-proc-mappings.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> b/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> index 7b596ac21b..5e3e5a2fb7 100644
> --- a/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> +++ b/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> @@ -33,7 +33,8 @@ def run_test():
>              return
>          raise
>      report(isinstance(mappings, str), "Fetched the mappings from the
> inferior")
> -    report("/sha1" in mappings, "Found the test binary name in the
> mappings")
> +    # Broken with host page size > guest page size
> +    # report("/sha1" in mappings, "Found the test binary name in the
> mappings")
>  
>  
>  def main():

I'll try to find a way to check host/guest page sizes in Python for
8.2. I think it's fine to disable the check for 8.1.

Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>


      reply	other threads:[~2023-08-09 11:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 23:49 [PATCH for-8.1] tests/tcg: Disable filename test for info proc mappings Richard Henderson
2023-08-09 10:59 ` Ilya Leoshkevich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26b47e37f11835201784dae30cebdd03b87ebdf4.camel@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).