From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRnH9-0001oi-8n for qemu-devel@nongnu.org; Mon, 25 Jul 2016 17:19:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRnH8-000672-Ab for qemu-devel@nongnu.org; Mon, 25 Jul 2016 17:18:59 -0400 References: <1469182567-3114-1-git-send-email-wangww.fnst@cn.fujitsu.com> <1469182567-3114-3-git-send-email-wangww.fnst@cn.fujitsu.com> From: Max Reitz Message-ID: <26e14cef-52af-14b2-fa0f-802d568ae638@redhat.com> Date: Mon, 25 Jul 2016 23:18:47 +0200 MIME-Version: 1.0 In-Reply-To: <1469182567-3114-3-git-send-email-wangww.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gaM4kLQw86daiNqTbwpdV38cLBE5b50RQ" Subject: Re: [Qemu-devel] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wang WeiWei , qemu devel , qemu block , Stefan Hajnoczi , Fam Zheng , Kevin Wolf , Jeff Cody Cc: Paolo Bonzini , John Snow , Eric Blake , Markus Armbruster , "Dr. David Alan Gilbert" , Dong Eddie , Jiang Yunhong , zhanghailiang , Gonglei , Wen Congyang , Changlong Xie This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gaM4kLQw86daiNqTbwpdV38cLBE5b50RQ From: Max Reitz To: Wang WeiWei , qemu devel , qemu block , Stefan Hajnoczi , Fam Zheng , Kevin Wolf , Jeff Cody Cc: Paolo Bonzini , John Snow , Eric Blake , Markus Armbruster , "Dr. David Alan Gilbert" , Dong Eddie , Jiang Yunhong , zhanghailiang , Gonglei , Wen Congyang , Changlong Xie Message-ID: <26e14cef-52af-14b2-fa0f-802d568ae638@redhat.com> Subject: Re: [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint References: <1469182567-3114-1-git-send-email-wangww.fnst@cn.fujitsu.com> <1469182567-3114-3-git-send-email-wangww.fnst@cn.fujitsu.com> In-Reply-To: <1469182567-3114-3-git-send-email-wangww.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 22.07.2016 12:15, Wang WeiWei wrote: > From: Wen Congyang >=20 > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie > Signed-off-by: Wang WeiWei > --- > block/backup.c | 18 ++++++++++++++++++ > include/block/block_backup.h | 3 +++ > 2 files changed, 21 insertions(+) > create mode 100644 include/block/block_backup.h [...] > diff --git a/include/block/block_backup.h b/include/block/block_backup.= h > new file mode 100644 > index 0000000..3753bcb > --- /dev/null > +++ b/include/block/block_backup.h > @@ -0,0 +1,3 @@ > +#include "block/block_int.h" > + > +void backup_do_checkpoint(BlockJob *job, Error **errp); Include guards and copyright notice missing. I don't mind the missing copyright notice because it will default to GPL anyway. Also, I personally don't really mind the missing include guards, but I thought I'd say something anyway. Max --gaM4kLQw86daiNqTbwpdV38cLBE5b50RQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXloI3EhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrTs1 CACJHNwlXkjGU3KhY9rc76Ly5B+dEQz0ZooDtX21rPME4AD+GulwxWlnAu/X7lFZ Oc360yFxLAKPFyrOFl4aaEMgF//QD6DCkr1QkgHDEnh+QCOgT0eaaHuVaKZQovgU 8zRxpE7cQCAkU8BSmuZl3U/mMQae1pDfNl/K7zv0A2Uq3ulzfBdIePvDMu8ikq1x tuZLoK6kURnsnntCLKOIBI5Mm0Vzv99iVXGiXGe2TpOwYm4whOqQ+9XHctiJ65N6 X2MT/+1+27+vxirj2IBNxTze9i2DoxLWwC1SCRf/nDwPDeA4ZEw46RAbgx59jU9C M4QI3KAvHWoGJ8CewL8VhgSg =379Q -----END PGP SIGNATURE----- --gaM4kLQw86daiNqTbwpdV38cLBE5b50RQ--