From: Jason Wang <jasowang@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL 00/33] Net patches
Date: Wed, 17 Jun 2020 14:19:41 +0800 [thread overview]
Message-ID: <26e8805c-08ba-5f09-85b9-dbe973e58164@redhat.com> (raw)
In-Reply-To: <CAFEAcA-7sG8_oOL+f=Q8dSevX-c26GeAcrLU6Ah6mOApfzizKQ@mail.gmail.com>
On 2020/6/16 下午8:32, Peter Maydell wrote:
> On Tue, 16 Jun 2020 at 07:45, Jason Wang <jasowang@redhat.com> wrote:
>> The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb:
>>
>> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2020-06-12 23:06:22 +0100)
>>
>> are available in the git repository at:
>>
>> https://github.com/jasowang/qemu.git tags/net-pull-request
>>
>> for you to fetch changes up to 955aab203f932b8a7c23ff9c58ba036997cb3ed8:
>>
>> net: Drop the NetLegacy structure, always use Netdev instead (2020-06-16 14:40:40 +0800)
>>
>> ----------------------------------------------------------------
>>
>> ----------------------------------------------------------------
> Hi; I'm afraid this fails to build (all hosts):
>
> hw/net/virtio-net.o: In function `virtio_net_device_realize':
> /home/pm215/qemu/hw/net/virtio-net.c:3380: undefined reference to
> `net_rx_pkt_init'
> hw/net/virtio-net.o: In function `virtio_net_device_unrealize':
> /home/pm215/qemu/hw/net/virtio-net.c:3418: undefined reference to
> `net_rx_pkt_uninit'
> hw/net/virtio-net.o: In function `virtio_net_process_rss':
> /home/pm215/qemu/hw/net/virtio-net.c:1607: undefined reference to
> `net_rx_pkt_set_protocols'
> /home/pm215/qemu/hw/net/virtio-net.c:1609: undefined reference to
> `net_rx_pkt_get_protocols'
> /home/pm215/qemu/hw/net/virtio-net.c:1625: undefined reference to
> `net_rx_pkt_calc_rss_hash'
> /home/pm215/qemu/hw/net/virtio-net.c:1613: undefined reference to
> `net_rx_pkt_get_ip6_info'
> /home/pm215/qemu/hw/net/virtio-net.c:1610: undefined reference to
> `net_rx_pkt_get_ip4_info'
> collect2: error: ld returned 1 exit status
>
> thanks
> -- PMM
>
Sorry for the failure.
This is because net_rx_pkt.c and net_tx_pkt.c are not complied when
CONFIG_VIRTIO_NET is set. And it may work by chance if E1000E and
VMXNET3 is enabled which is the case I test.
Will send V2.
Thanks
prev parent reply other threads:[~2020-06-17 6:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 6:45 [PULL 00/33] Net patches Jason Wang
2020-06-16 6:45 ` [PULL 01/33] virtio-net: implement RSS configuration command Jason Wang
2020-06-16 6:45 ` [PULL 02/33] virtio-net: implement RX RSS processing Jason Wang
2020-06-16 6:45 ` [PULL 03/33] tap: allow extended virtio header with hash info Jason Wang
2020-06-16 6:45 ` [PULL 04/33] virtio-net: reference implementation of hash report Jason Wang
2020-06-16 6:45 ` [PULL 05/33] vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro Jason Wang
2020-06-16 6:45 ` [PULL 06/33] virtio-net: add migration support for RSS and hash report Jason Wang
2020-06-16 6:45 ` [PULL 07/33] virtio-net: align RSC fields with updated virtio-net header Jason Wang
2020-06-16 6:45 ` [PULL 08/33] Fix tulip breakage Jason Wang
2020-06-16 6:45 ` [PULL 09/33] hw/net/tulip: Fix 'Descriptor Error' definition Jason Wang
2020-06-16 6:45 ` [PULL 10/33] hw/net/tulip: Log descriptor overflows Jason Wang
2020-06-16 6:45 ` [PULL 11/33] net: cadence_gem: Fix debug statements Jason Wang
2020-06-16 6:45 ` [PULL 12/33] net: cadence_gem: Fix the queue address update during wrap around Jason Wang
2020-06-16 6:45 ` [PULL 13/33] net: cadence_gem: Fix irq update w.r.t queue Jason Wang
2020-06-16 6:45 ` [PULL 14/33] net: cadence_gem: Define access permission for interrupt registers Jason Wang
2020-06-16 6:45 ` [PULL 15/33] net: cadence_gem: Set ISR according to queue in use Jason Wang
2020-06-16 6:45 ` [PULL 16/33] net: cadence_gem: Move tx/rx packet buffert to CadenceGEMState Jason Wang
2020-06-16 6:45 ` [PULL 17/33] net: cadence_gem: Fix up code style Jason Wang
2020-06-16 6:45 ` [PULL 18/33] net: cadence_gem: Add support for jumbo frames Jason Wang
2020-06-16 6:45 ` [PULL 19/33] net: cadnece_gem: Update irq_read_clear field of designcfg_debug1 reg Jason Wang
2020-06-16 6:45 ` [PULL 20/33] net: cadence_gem: Update the reset value for interrupt mask register Jason Wang
2020-06-16 6:45 ` [PULL 21/33] net: cadence_gem: TX_LAST bit should be set by guest Jason Wang
2020-06-16 6:45 ` [PULL 22/33] net: cadence_gem: Fix RX address filtering Jason Wang
2020-06-16 6:45 ` [PULL 23/33] net: use peer when purging queue in qemu_flush_or_purge_queue_packets() Jason Wang
2020-06-16 6:45 ` [PULL 24/33] net/colo-compare.c: Create event_bh with the right AioContext Jason Wang
2020-06-16 6:45 ` [PULL 25/33] chardev/char.c: Use qemu_co_sleep_ns if in coroutine Jason Wang
2020-06-16 6:45 ` [PULL 26/33] net/colo-compare.c: Fix deadlock in compare_chr_send Jason Wang
2020-06-16 6:45 ` [PULL 27/33] net/colo-compare.c: Only hexdump packets if tracing is enabled Jason Wang
2020-06-16 6:45 ` [PULL 28/33] net/colo-compare.c: Check that colo-compare is active Jason Wang
2020-06-16 6:45 ` [PULL 29/33] net/colo-compare.c: Correct ordering in complete and finalize Jason Wang
2020-06-16 6:45 ` [PULL 30/33] colo-compare: Fix memory leak in packet_enqueue() Jason Wang
2020-06-16 6:45 ` [PULL 31/33] hw/net/e1000e: Do not abort() on invalid PSRCTL register value Jason Wang
2020-06-16 6:45 ` [PULL 32/33] net: Drop the legacy "name" parameter from the -net option Jason Wang
2020-06-16 6:45 ` [PULL 33/33] net: Drop the NetLegacy structure, always use Netdev instead Jason Wang
2020-06-16 12:32 ` [PULL 00/33] Net patches Peter Maydell
2020-06-17 6:19 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26e8805c-08ba-5f09-85b9-dbe973e58164@redhat.com \
--to=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).