From: Richard Henderson <richard.henderson@linaro.org>
To: "Thomas Weißschuh" <thomas@t-8ch.de>,
"Laurent Vivier" <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 0/2] linux-user: two fixes to coredump generation
Date: Wed, 10 Jan 2024 08:33:11 +1100 [thread overview]
Message-ID: <26f604c1-f3e6-4ae8-a502-a7b92c1c1d30@linaro.org> (raw)
In-Reply-To: <20240107-qemu-user-dumpable-v2-0-54e3bcfc00c9@t-8ch.de>
On 1/8/24 01:01, Thomas Weißschuh wrote:
> Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
> ---
> Changes in v2:
> - Rebase on 8.2 master
> - Resend after closed tree and holidays
> - Link to v1: https://lore.kernel.org/r/20231115-qemu-user-dumpable-v1-0-edbe7f0fbb02@t-8ch.de
>
> ---
> Thomas Weißschuh (2):
> linux-user/elfload: test return value of getrlimit
> linux-user/elfload: check PR_GET_DUMPABLE before creating coredump
>
> linux-user/elfload.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
> ---
> base-commit: 0c1eccd368af8805ec0fb11e6cf25d0684d37328
> change-id: 20231115-qemu-user-dumpable-d499c0396103
>
> Best regards,
Both patches look good for correctness, but both have style issues: need braces on those
if statements.
With that fixed,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-01-09 21:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-07 14:01 [PATCH v2 0/2] linux-user: two fixes to coredump generation Thomas Weißschuh
2024-01-07 14:01 ` [PATCH v2 1/2] linux-user/elfload: test return value of getrlimit Thomas Weißschuh
2024-01-07 14:01 ` [PATCH v2 2/2] linux-user/elfload: check PR_GET_DUMPABLE before creating coredump Thomas Weißschuh
2024-01-09 21:33 ` Richard Henderson [this message]
2024-01-09 21:59 ` Re: [PATCH v2 0/2] linux-user: two fixes to coredump generation Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26f604c1-f3e6-4ae8-a502-a7b92c1c1d30@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=thomas@t-8ch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).