From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3spQ-0000I7-SE for qemu-devel@nongnu.org; Mon, 07 Nov 2016 17:55:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3spN-0002DB-Q9 for qemu-devel@nongnu.org; Mon, 07 Nov 2016 17:55:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33610) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3spN-0002D6-IR for qemu-devel@nongnu.org; Mon, 07 Nov 2016 17:55:45 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AFB0731B320 for ; Mon, 7 Nov 2016 22:55:44 +0000 (UTC) References: <20161107073033.21025-1-marcandre.lureau@redhat.com> <20161107073033.21025-2-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <26f6d7c0-b8d2-6368-4a6e-a2ec3ed51da1@redhat.com> Date: Mon, 7 Nov 2016 16:55:43 -0600 MIME-Version: 1.0 In-Reply-To: <20161107073033.21025-2-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IglQ2G1SSj1JKJLXjSX3HNPxTrjv9Tbcw" Subject: Re: [Qemu-devel] [PATCH v3 01/14] qapi: add missing 'bus' argument in device_add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IglQ2G1SSj1JKJLXjSX3HNPxTrjv9Tbcw From: Eric Blake To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: armbru@redhat.com Message-ID: <26f6d7c0-b8d2-6368-4a6e-a2ec3ed51da1@redhat.com> Subject: Re: [PATCH v3 01/14] qapi: add missing 'bus' argument in device_add References: <20161107073033.21025-1-marcandre.lureau@redhat.com> <20161107073033.21025-2-marcandre.lureau@redhat.com> In-Reply-To: <20161107073033.21025-2-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/07/2016 01:30 AM, Marc-Andr=C3=A9 Lureau wrote: > 'device_add' is incomplete for now, but 'bus' is a common argument for > regarless of the device, and is present in documentation. Add it to the= s/regarless/regardless/ > device_add schema definition. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > qapi-schema.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index b0b4bf6..4ba5772 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2317,7 +2317,7 @@ > # Since: 0.13 > ## > { 'command': 'device_add', > - 'data': {'driver': 'str', 'id': 'str'}, > + 'data': {'driver': 'str', '*bus': 'str', 'id': 'str'}, > 'gen': false } # so we can get the additional arguments > =20 > ## >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IglQ2G1SSj1JKJLXjSX3HNPxTrjv9Tbcw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYIQZvAAoJEKeha0olJ0NqfNkH/R7z+UZ4aZS2vPLRnbuwZhj7 Aq4mii+sT+FU7GLK+91X2Tz4mpMHiTbcBPrqhfo+nWgUHdItmjkobSY4SnUJzvw9 OzdEBV7Dqmt8lHdUGZlxydGXv60eyWxnXeizj4HqCbvHSYGT4i+nUdHTlH2GEwiC UvVTATMtddPxlV/1HiRnd/8O9MTJypnB+4oytVRx/u49sVESJ4ge7/Zsl4dKesgi zbai2v9Lnh5MqEn2JBLgtIv2NxPaheqWRAk84SGiuJjsOsm+Fs0pEJZXy2i/vmOS b5T/3gm9NSARgLdzbJOV/LK2qPaleDn7dUk3bTii7H4KEf8A/iya0TQ9ZqEbmoM= =X0KI -----END PGP SIGNATURE----- --IglQ2G1SSj1JKJLXjSX3HNPxTrjv9Tbcw--