From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49865) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIMkL-0006Xw-BR for qemu-devel@nongnu.org; Tue, 06 Jun 2017 18:14:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIMkK-0004pr-Go for qemu-devel@nongnu.org; Tue, 06 Jun 2017 18:14:41 -0400 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:35710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dIMkK-0004pe-AM for qemu-devel@nongnu.org; Tue, 06 Jun 2017 18:14:40 -0400 Received: by mail-wm0-x22c.google.com with SMTP id x70so46345804wme.0 for ; Tue, 06 Jun 2017 15:14:40 -0700 (PDT) Sender: Paolo Bonzini References: <2b2311b1b070a0b03973e39deccf4682de4a6cd4.1496686997.git.alistair.francis@xilinx.com> From: Paolo Bonzini Message-ID: <270686d0-1ca8-965f-a14a-397f45616deb@redhat.com> Date: Wed, 7 Jun 2017 00:14:37 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , "qemu-devel@nongnu.org Developers" , Gerd Hoffmann On 06/06/2017 18:30, Alistair Francis wrote: >> >> This is somehow confusing. I don't think it is worth having another >> qemu_log_stderr() function rather than using error_report() but this very >> call might deserve a comment explaining this unusual use. What do you think? > > The problem with stderr is that this isn't an error. Some uses of QEMU > (inside Eclipse for example) flag everything printed on stderr as red > which confuses users that they are seeing an error when they really > aren't. But they are wrong. Would it work for you to work around it, by making QEMU use a client (connect) rather than a server (listen) socket? > Also all the uses of this message that I have seen (there are probably > others though) stops QEMU until the connection is made, which means it > doesn't matter if it is mixed up in console output. It may not mix up, but it would break programs expecting only console output to be on stdout. > I just think that this message to most users isn't helpful and they > probably don't even read it, so printing to stderr seems like a bit > much. I would compare it with dd's output. It goes to stderr even though it's not an error. Paolo