From: Richard Henderson <richard.henderson@linaro.org>
To: "Claudio Fontana" <cfontana@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v22 14/17] i386: split seg_helper into user-only and sysemu parts
Date: Wed, 24 Feb 2021 19:57:16 -0800 [thread overview]
Message-ID: <270c65bc-54a4-01b2-6fde-d59784cb455f@linaro.org> (raw)
In-Reply-To: <20210224133428.14071-15-cfontana@suse.de>
On 2/24/21 5:34 AM, Claudio Fontana wrote:
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> ---
> target/i386/tcg/helper-tcg.h | 5 +
> target/i386/tcg/seg_helper.h | 66 ++++++++
> target/i386/tcg/seg_helper.c | 233 +---------------------------
> target/i386/tcg/sysemu/seg_helper.c | 125 +++++++++++++++
> target/i386/tcg/user/seg_helper.c | 109 +++++++++++++
> target/i386/tcg/sysemu/meson.build | 1 +
> target/i386/tcg/user/meson.build | 1 +
> 7 files changed, 311 insertions(+), 229 deletions(-)
> create mode 100644 target/i386/tcg/seg_helper.h
> create mode 100644 target/i386/tcg/sysemu/seg_helper.c
> create mode 100644 target/i386/tcg/user/seg_helper.c
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Not your bug, but for the record:
> +void cpu_x86_load_seg(CPUX86State *env, X86Seg seg_reg, int selector)
> +{
> + if (!(env->cr[0] & CR0_PE_MASK) || (env->eflags & VM_MASK)) {
This first test is always false for user-only. The second can be true via the
vm86(2) syscall.
> + int dpl = (env->eflags & VM_MASK) ? 3 : 0;
so this second test becomes redundant.
> + selector &= 0xffff;
> + cpu_x86_load_seg_cache(env, seg_reg, selector,
> + (selector << 4), 0xffff,
> + DESC_P_MASK | DESC_S_MASK | DESC_W_MASK |
> + DESC_A_MASK | (dpl << DESC_DPL_SHIFT));
> + } else {
> + helper_load_seg(env, seg_reg, selector);
> + }
And helper_load_seg calls GETPC(), so suffers from the same problem as the fpu
helpers.
r~
next prev parent reply other threads:[~2021-02-25 3:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 13:34 [PATCH v22 00/17] i386 cleanup PART 2 Claudio Fontana
2021-02-24 13:34 ` [PATCH v22 01/17] i386: split cpu accelerators from cpu.c, using AccelCPUClass Claudio Fontana
2021-02-25 1:23 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 02/17] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn Claudio Fontana
2021-02-25 1:25 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 03/17] accel: introduce new accessor functions Claudio Fontana
2021-02-25 1:26 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 04/17] target/i386: fix host_cpu_adjust_phys_bits error handling Claudio Fontana
2021-02-24 13:34 ` [PATCH v22 05/17] accel-cpu: make cpu_realizefn return a bool Claudio Fontana
2021-02-24 13:34 ` [PATCH v22 06/17] meson: add target_user_arch Claudio Fontana
2021-02-24 21:21 ` Philippe Mathieu-Daudé
2021-02-24 22:35 ` Eric Blake
2021-02-24 22:53 ` Philippe Mathieu-Daudé
2021-02-25 7:16 ` Claudio Fontana
2021-02-24 13:34 ` [PATCH v22 07/17] i386: split off sysemu-only functionality in tcg-cpu Claudio Fontana
2021-02-25 1:30 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 08/17] i386: split smm helper (sysemu) Claudio Fontana
2021-02-25 1:32 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 09/17] i386: split tcg excp_helper into sysemu and user parts Claudio Fontana
2021-02-25 1:33 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 10/17] i386: move TCG btp_helper into sysemu/ Claudio Fontana
2021-02-25 1:40 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 11/17] i386: split misc helper into user and sysemu parts Claudio Fontana
2021-02-25 3:14 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 12/17] i386: separate fpu_helper " Claudio Fontana
2021-02-25 3:28 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 13/17] i386: split svm_helper into sysemu and stub-only user Claudio Fontana
2021-02-25 3:37 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 14/17] i386: split seg_helper into user-only and sysemu parts Claudio Fontana
2021-02-25 3:57 ` Richard Henderson [this message]
2021-02-24 13:34 ` [PATCH v22 15/17] i386: split off sysemu part of cpu.c Claudio Fontana
2021-02-25 4:02 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 16/17] i386: gdbstub: only write CR0/CR2/CR3/EFER for SOFTMMU Claudio Fontana
2021-02-25 4:19 ` Richard Henderson
2021-02-25 8:55 ` Claudio Fontana
2021-02-26 4:05 ` Richard Henderson
2021-02-26 9:22 ` Claudio Fontana
2021-02-26 15:07 ` Richard Henderson
2021-02-24 13:34 ` [PATCH v22 17/17] i386: move cpu_load_efer into sysemu-only section of cpu.h Claudio Fontana
2021-02-25 4:28 ` Richard Henderson
2021-02-25 9:02 ` Claudio Fontana
2021-02-24 14:12 ` [PATCH v22 00/17] i386 cleanup PART 2 no-reply
2021-02-24 22:54 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=270c65bc-54a4-01b2-6fde-d59784cb455f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).