qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Qemu-block <qemu-block@nongnu.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Alberto Garcia <berto@igalia.com>
Subject: [Qemu-devel] Consistency of iotests 093 and 136
Date: Wed, 23 Jan 2019 18:00:49 +0100	[thread overview]
Message-ID: <271482fe-741a-6a15-15fd-181d4e55a8c4@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

Hi,

093 and 136 seem really flaky to me.  I can reproduce that by running:

$ dd if=/dev/urandom of=/dev/null

in as many shells as I have CPU cores, and then run the tests:

$ while TEST_DIR=/tmp/t0 ./check -T -raw 93; do; done

or

$ while TEST_DIR=/tmp/t0 ./check -T -raw 136; do; done

which usually fail after one or two iterations.


The exact failures vary, but for 093 it's usually something that ends with:

[...]
    self.assertTrue(check_limit(params['iops'], rd_iops + wr_iops))
AssertionError: False is not true

Or:

[...]
    self.assertTrue(check_limit(params['iops_rd'], rd_iops))
AssertionError: False is not true

etc. -- so the 10 % error range doesn't seem to be enough, I'd say.  But
will just increasing it solve the problem?


And for 136 it's usually (always?):

[...]
  File "136", line 278, in do_test_stats
    self.check_values()
  File "136", line 204, in check_values
    self.assertLess(0, stats['idle_time_ns'])
AssertionError: 0 not less than 0


Any ideas on making these more reliable?


Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2019-01-23 17:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 17:00 Max Reitz [this message]
2019-01-24 10:11 ` [Qemu-devel] Consistency of iotests 093 and 136 Alberto Garcia
2019-01-24 14:34   ` Alberto Garcia
2019-01-24 18:07     ` Eric Blake
2019-01-28 15:18       ` Alberto Garcia
2019-01-28 18:38         ` Markus Armbruster
2019-01-29 10:03           ` Alberto Garcia
2019-01-29 12:11             ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=271482fe-741a-6a15-15fd-181d4e55a8c4@redhat.com \
    --to=mreitz@redhat.com \
    --cc=berto@igalia.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).