From: Eric Blake <eblake@redhat.com>
To: Like Xu <like.xu@linux.intel.com>, qemu-trivial@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] doc: update .gitignore and fix typos for docs in tree
Date: Tue, 19 Feb 2019 21:09:19 -0600 [thread overview]
Message-ID: <27254af5-b490-165f-8ca3-f60ab7642d72@redhat.com> (raw)
In-Reply-To: <1550652953-24393-1-git-send-email-like.xu@linux.intel.com>
On 2/20/19 2:55 AM, Like Xu wrote:
> Signed-off-by: Like Xu <like.xu@linux.intel.com>
This feels like two independent patches - the .gitignore change is
different from typo fixes.
Actually, for .gitignore, you could just as easily do:
echo '*.patch' >> .git/info/exclude
and fix it so you never commit patch files locally, while still leaving
them visible through 'git status' to other users. I actually like
knowing when I have stale patch files lying around, so that I can 'rm'
them before creating my next patch batch and using 'git send-email
*.patch' - but of course, I could just as easily add '!*.patch' to my
.git/info/exclude to override the project default if we decide to go
with your patch.
> +++ b/docs/colo-proxy.txt
> @@ -41,7 +41,7 @@ Below is a COLO proxy ascii figure:
> | | +------------------------------------------------------+ | | | |
> |netfilter| | | | | | netfilter | | |
> | +----------+ +----------------------------+ | | | +-----------------------------------------------------------+ |
> -| | | | | | out | | | | | | filter excute order | |
> +| | | | | | out | | | | | | filter execute order | |
You fixed the typo, but broke the whitespacing on this lineart. (twice)
> +++ b/docs/qemu-block-drivers.texi
> @@ -632,7 +632,7 @@ qemu-system-i386 -drive file=iscsi://127.0.0.1/iqn.qemu.test/1 \
> @end example
>
>
> -Howto set up a simple iSCSI target on loopback and accessing it via QEMU:
> +How to set up a simple iSCSI target on loopback and accessing it via QEMU:
While here, I would also: s/accessing/access/
> +++ b/docs/usb-storage.txt
> @@ -16,7 +16,7 @@ too):
>
>
> Number two is the newer usb attached scsi transport. This one doesn't
> -automagically create a scsi disk, so you have to explicitly attach one
> +automatically create a scsi disk, so you have to explicitly attach one
This one may be intentional, as a play on English words. But changing it
may sound a bit more professional.
All your other typo fixes are good. Looking forward to v2.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-02-20 3:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 8:55 [Qemu-devel] [PATCH] doc: update .gitignore and fix typos for docs in tree Like Xu
2019-02-20 3:00 ` Wei Yang
2019-02-20 3:09 ` Eric Blake [this message]
2019-02-20 5:39 ` Like Xu
2019-02-20 13:45 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27254af5-b490-165f-8ca3-f60ab7642d72@redhat.com \
--to=eblake@redhat.com \
--cc=laurent@vivier.eu \
--cc=like.xu@linux.intel.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).