From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:47073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwIGR-0006eU-QB for qemu-devel@nongnu.org; Tue, 19 Feb 2019 22:09:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwIGI-00067P-NV for qemu-devel@nongnu.org; Tue, 19 Feb 2019 22:09:34 -0500 References: <1550652953-24393-1-git-send-email-like.xu@linux.intel.com> From: Eric Blake Message-ID: <27254af5-b490-165f-8ca3-f60ab7642d72@redhat.com> Date: Tue, 19 Feb 2019 21:09:19 -0600 MIME-Version: 1.0 In-Reply-To: <1550652953-24393-1-git-send-email-like.xu@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] doc: update .gitignore and fix typos for docs in tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Like Xu , qemu-trivial@nongnu.org Cc: Laurent Vivier , qemu-devel@nongnu.org On 2/20/19 2:55 AM, Like Xu wrote: > Signed-off-by: Like Xu This feels like two independent patches - the .gitignore change is different from typo fixes. Actually, for .gitignore, you could just as easily do: echo '*.patch' >> .git/info/exclude and fix it so you never commit patch files locally, while still leaving them visible through 'git status' to other users. I actually like knowing when I have stale patch files lying around, so that I can 'rm' them before creating my next patch batch and using 'git send-email *.patch' - but of course, I could just as easily add '!*.patch' to my .git/info/exclude to override the project default if we decide to go with your patch. > +++ b/docs/colo-proxy.txt > @@ -41,7 +41,7 @@ Below is a COLO proxy ascii figure: > | | +------------------------------------------------------+ | | | | > |netfilter| | | | | | netfilter | | | > | +----------+ +----------------------------+ | | | +-----------------------------------------------------------+ | > -| | | | | | out | | | | | | filter excute order | | > +| | | | | | out | | | | | | filter execute order | | You fixed the typo, but broke the whitespacing on this lineart. (twice) > +++ b/docs/qemu-block-drivers.texi > @@ -632,7 +632,7 @@ qemu-system-i386 -drive file=iscsi://127.0.0.1/iqn.qemu.test/1 \ > @end example > > > -Howto set up a simple iSCSI target on loopback and accessing it via QEMU: > +How to set up a simple iSCSI target on loopback and accessing it via QEMU: While here, I would also: s/accessing/access/ > +++ b/docs/usb-storage.txt > @@ -16,7 +16,7 @@ too): > > > Number two is the newer usb attached scsi transport. This one doesn't > -automagically create a scsi disk, so you have to explicitly attach one > +automatically create a scsi disk, so you have to explicitly attach one This one may be intentional, as a play on English words. But changing it may sound a bit more professional. All your other typo fixes are good. Looking forward to v2. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org