From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Roman Bolshakov <roman@roolebo.dev>
Cc: qemu-devel@nongnu.org, Roman Bolshakov <rbolshakov@ddn.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Cameron Esfahani <dirty@apple.com>
Subject: Re: [PATCH 2/2] sysemu/kvm: Restrict hvf_get_supported_cpuid() to x86 targets
Date: Wed, 4 Oct 2023 11:25:04 +0200 [thread overview]
Message-ID: <273f280c-22f5-7dc3-4410-01f6f4c67c8e@linaro.org> (raw)
In-Reply-To: <ZP4uPozEl3pjY2qg@MacBook-Air-Roman.local>
On 10/9/23 22:59, Roman Bolshakov wrote:
> On Tue, Sep 05, 2023 at 02:39:06PM +0200, Philippe Mathieu-Daudé wrote:
>> hvf_get_supported_cpuid() is only defined for x86 targets
>> (in target/i386/hvf/x86_cpuid.c).
>> Its declaration is pointless on all other targets.
>>
>> All the calls to it in target/i386/cpu.c are guarded by
>> a call on hvf_enabled(), so are elided when HVF is not
>> built in. Therefore we can remove the unnecessary function
>> stub.
>>
>
> Looks good but you also need to include "hvf/hvf-i386.h" to
> target/i386/hvf/hvf-cpu.c, otherwise the build fails.
Oops, thanks for testing!
prev parent reply other threads:[~2023-10-04 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 12:39 [PATCH 0/2] sysemu/accel: Simplify sysemu/hvf.h Philippe Mathieu-Daudé
2023-09-05 12:39 ` [PATCH 1/2] target/i386/hvf: Remove unused includes in 'hvf-i386.h' Philippe Mathieu-Daudé
2023-09-10 20:54 ` Roman Bolshakov
2023-09-05 12:39 ` [PATCH 2/2] sysemu/kvm: Restrict hvf_get_supported_cpuid() to x86 targets Philippe Mathieu-Daudé
2023-09-10 20:59 ` Roman Bolshakov
2023-10-04 9:25 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=273f280c-22f5-7dc3-4410-01f6f4c67c8e@linaro.org \
--to=philmd@linaro.org \
--cc=dirty@apple.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=roman@roolebo.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).