Re: [Qemu-devel] [PATCH v3 for-2.13 1/3] net: Remove the deprecated "vlan" parameter

[Thomas Huth <thuth@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

On 17.04.2018 09:21, Stefan Hajnoczi wrote:
> On Mon, Apr 16, 2018 at 08:44:39AM +0200, Thomas Huth wrote:
>> @@ -499,10 +497,11 @@
>>  # @opts: device type specific properties (legacy)
>>  #
>>  # Since: 1.2
>> +#
>> +# 'vlan' - removed with 2.12
> 
> Not sure how to interpret this.  How about "removed in 2.13"?

Sure, will change it.

>> @@ -2028,10 +2028,9 @@ DEF("nic", HAS_ARG, QEMU_OPTION_nic,
>>      "                provided a 'user' network connection)\n",
>>      QEMU_ARCH_ALL)
>>  DEF("net", HAS_ARG, QEMU_OPTION_net,
>> -    "-net nic[,vlan=n][,netdev=nd][,macaddr=mac][,model=type][,name=str][,addr=str][,vectors=v]\n"
>> +    "-net nic[,macaddr=mac][,model=type][,name=str][,addr=str][,vectors=v]\n"
>>      "                configure or create an on-board (or machine default) NIC and\n"
>> -    "                connect it either to VLAN 'n' or the netdev 'nd' (for pluggable\n"
>> -    "                NICs please use '-device devtype,netdev=nd' instead)\n"
>> +    "                connect it to hub 0 (please use -nic for direct connections)\n"
> 
> What does "direct connections" means?

I mean a 1:1 connection between the backend and frontend here, without a
hub inbetween. Can you think of a better wording?

 Thomas


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]