From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Hanna Reitz <hreitz@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH 2/7] block/nbd: Delete open timer when done
Date: Fri, 4 Feb 2022 11:52:58 +0300 [thread overview]
Message-ID: <277e7d4d-dfde-86c4-559e-2e8aaa2a0612@virtuozzo.com> (raw)
In-Reply-To: <20220203163024.38913-3-hreitz@redhat.com>
03.02.2022 19:30, Hanna Reitz wrote:
> We start the open timer to cancel the connection attempt after a while.
> Once nbd_do_establish_connection() has returned, the attempt is over,
> and we no longer need the timer.
>
> Delete it before returning from nbd_open(), so that it does not persist
> for longer. It has no use after nbd_open(), and just like the reconnect
> delay timer, it might well be dangerous if it were to fire afterwards.
>
> Signed-off-by: Hanna Reitz<hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2022-02-04 9:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 16:30 [PATCH 0/7] block/nbd: Move s->ioc on AioContext change Hanna Reitz
2022-02-03 16:30 ` [PATCH 1/7] block/nbd: Delete reconnect delay timer when done Hanna Reitz
2022-02-04 8:50 ` Vladimir Sementsov-Ogievskiy
2022-02-03 16:30 ` [PATCH 2/7] block/nbd: Delete open " Hanna Reitz
2022-02-04 8:52 ` Vladimir Sementsov-Ogievskiy [this message]
2022-02-03 16:30 ` [PATCH 3/7] block/nbd: Assert there are no timers when closed Hanna Reitz
2022-02-04 8:54 ` Vladimir Sementsov-Ogievskiy
2022-02-03 16:30 ` [PATCH 4/7] iotests.py: Add QemuStorageDaemon class Hanna Reitz
2022-02-04 9:04 ` Vladimir Sementsov-Ogievskiy
2022-02-04 9:58 ` Hanna Reitz
2022-02-03 16:30 ` [PATCH 5/7] iotests/281: Test lingering timers Hanna Reitz
2022-02-04 9:17 ` Vladimir Sementsov-Ogievskiy
2022-02-03 16:30 ` [PATCH 6/7] block/nbd: Move s->ioc on AioContext change Hanna Reitz
2022-02-04 9:20 ` Vladimir Sementsov-Ogievskiy
2022-02-03 16:30 ` [PATCH 7/7] iotests/281: Let NBD connection yield in iothread Hanna Reitz
2022-02-04 9:31 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=277e7d4d-dfde-86c4-559e-2e8aaa2a0612@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).