* [RFC PATCH] gitlab: work harder to avoid false positives in checkpatch
@ 2021-06-02 15:32 Alex Bennée
2021-06-02 15:36 ` Philippe Mathieu-Daudé
2021-06-04 17:18 ` Wainer dos Santos Moschetta
0 siblings, 2 replies; 3+ messages in thread
From: Alex Bennée @ 2021-06-02 15:32 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, berrange, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Willian Rampazzo, Alex Bennée
This copies the behaviour of patchew's configuration to make the diff
algorithm generate a minimal diff.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
.gitlab-ci.d/static_checks.yml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/.gitlab-ci.d/static_checks.yml b/.gitlab-ci.d/static_checks.yml
index 91247a6f67..ec09da799d 100644
--- a/.gitlab-ci.d/static_checks.yml
+++ b/.gitlab-ci.d/static_checks.yml
@@ -3,7 +3,11 @@ check-patch:
image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
needs:
job: amd64-centos8-container
- script: .gitlab-ci.d/check-patch.py
+ script:
+ - git config --local diff.renamelimit 0
+ - git config --local diff.renames True
+ - git config --local diff.algorithm histogram
+ - .gitlab-ci.d/check-patch.py
variables:
GIT_DEPTH: 1000
rules:
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] gitlab: work harder to avoid false positives in checkpatch
2021-06-02 15:32 [RFC PATCH] gitlab: work harder to avoid false positives in checkpatch Alex Bennée
@ 2021-06-02 15:36 ` Philippe Mathieu-Daudé
2021-06-04 17:18 ` Wainer dos Santos Moschetta
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-06-02 15:36 UTC (permalink / raw)
To: Alex Bennée, qemu-devel
Cc: Willian Rampazzo, Thomas Huth, berrange,
Wainer dos Santos Moschetta
On 6/2/21 5:32 PM, Alex Bennée wrote:
> This copies the behaviour of patchew's configuration to make the diff
> algorithm generate a minimal diff.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> .gitlab-ci.d/static_checks.yml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] gitlab: work harder to avoid false positives in checkpatch
2021-06-02 15:32 [RFC PATCH] gitlab: work harder to avoid false positives in checkpatch Alex Bennée
2021-06-02 15:36 ` Philippe Mathieu-Daudé
@ 2021-06-04 17:18 ` Wainer dos Santos Moschetta
1 sibling, 0 replies; 3+ messages in thread
From: Wainer dos Santos Moschetta @ 2021-06-04 17:18 UTC (permalink / raw)
To: Alex Bennée, qemu-devel
Cc: Willian Rampazzo, Thomas Huth, berrange,
Philippe Mathieu-Daudé
Hi,
On 6/2/21 12:32 PM, Alex Bennée wrote:
> This copies the behaviour of patchew's configuration to make the diff
> algorithm generate a minimal diff.
I was intrigued on where you had found that configuration. Then I found
it myself here:
https://patchew.org/logs/20210604155532.1499282-1-jsnow@redhat.com/testing.checkpatch/?type=message
Assuming patchew has been doing the right thing, I think it is a good
idea to configure Git alike on CI.
Thus:
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> .gitlab-ci.d/static_checks.yml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.d/static_checks.yml b/.gitlab-ci.d/static_checks.yml
> index 91247a6f67..ec09da799d 100644
> --- a/.gitlab-ci.d/static_checks.yml
> +++ b/.gitlab-ci.d/static_checks.yml
> @@ -3,7 +3,11 @@ check-patch:
> image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
> needs:
> job: amd64-centos8-container
> - script: .gitlab-ci.d/check-patch.py
> + script:
> + - git config --local diff.renamelimit 0
> + - git config --local diff.renames True
> + - git config --local diff.algorithm histogram
> + - .gitlab-ci.d/check-patch.py
> variables:
> GIT_DEPTH: 1000
> rules:
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-04 17:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-02 15:32 [RFC PATCH] gitlab: work harder to avoid false positives in checkpatch Alex Bennée
2021-06-02 15:36 ` Philippe Mathieu-Daudé
2021-06-04 17:18 ` Wainer dos Santos Moschetta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).