From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38736)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1SQHnk-0002hb-6I
	for qemu-devel@nongnu.org; Fri, 04 May 2012 08:40:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1SQHnf-00060I-FP
	for qemu-devel@nongnu.org; Fri, 04 May 2012 08:39:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49793)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1SQHnf-0005xt-7O
	for qemu-devel@nongnu.org; Fri, 04 May 2012 08:39:55 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q44CdrCU030117
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 4 May 2012 08:39:53 -0400
From: Paul Moore <pmoore@redhat.com>
Date: Fri, 04 May 2012 08:39:38 -0400
Message-ID: <2782212.1uf5iltSMx@sifl>
In-Reply-To: <20120504085417.GD9419@redhat.com>
References: <20120503210045.30938.71447.stgit@sifl>
	<20120504085417.GD9419@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [Qemu-devel] [PATCH v3] vnc: disable VNC password
	authentication (security type 2) when in FIPS mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

On Friday, May 04, 2012 09:54:17 AM Daniel P. Berrange wrote:
> On Thu, May 03, 2012 at 05:00:45PM -0400, Paul Moore wrote:
> > FIPS 140-2 requires disabling certain ciphers, including DES, which is
> > used
> > by VNC to obscure passwords when they are sent over the network.  The
> > solution for FIPS users is to disable the use of VNC password auth when
> > the
> > host system is operating in FIPS mode.
> > 
> > This patch causes qemu to emit a syslog entry and a message to stderr when
> > the host system is running in FIPS mode and a VNC password was specified
> > on
> > the commend line.  If the system is not running in FIPS mode, or is
> > running
> > in FIPS mode but VNC password authentication was not requested, qemu
> > operates normally.
> > 
> > Signed-off-by: Paul Moore <pmoore@redhat.com>
> 
> Reviewed-by: Dainel P. Berrange <berrange@redhat.com>
> 
> Looks good to me now.

Thanks.

-- 
paul moore
security and virtualization @ redhat