From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, e.emanuelegiuseppe@gmail.com
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH] tests: virtio: separate ccw tests from libqos
Date: Wed, 1 Aug 2018 18:46:53 +0200 [thread overview]
Message-ID: <2782cf7d-214f-a408-e080-046c2b5a63d9@redhat.com> (raw)
In-Reply-To: <8dd02a8d-093f-5592-d4ee-50cc4fba6de9@redhat.com>
On 01/08/2018 18:39, Thomas Huth wrote:
> I think you could omit the virtio_net_nop test here, since we already
> check that device in tests/pxe-test.c (and maybe also virtio_blk and
> virtio_scsi since they are tested in tests/cdrom-test.c).
>
> Anyway:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Thanks Conny and Thomas for the quick review.
Emanuele, please add this patch to your qgraph branch! You can use "git
am -s" and cut-and-paste the original message source from thunderbird or
gmail into the Terminal.
Paolo
prev parent reply other threads:[~2018-08-01 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 13:27 [Qemu-devel] [PATCH] tests: virtio: separate ccw tests from libqos Paolo Bonzini
2018-08-01 13:34 ` Cornelia Huck
2018-08-01 16:39 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-08-01 16:46 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2782cf7d-214f-a408-e080-046c2b5a63d9@redhat.com \
--to=pbonzini@redhat.com \
--cc=e.emanuelegiuseppe@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).