From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F13E2C32751 for ; Wed, 7 Aug 2019 17:50:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE110222FC for ; Wed, 7 Aug 2019 17:50:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YSd01dq4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE110222FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvQ4m-00020t-Q6 for qemu-devel@archiver.kernel.org; Wed, 07 Aug 2019 13:50:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59051) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvQ48-0001BJ-BB for qemu-devel@nongnu.org; Wed, 07 Aug 2019 13:49:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvQ47-00085Y-2r for qemu-devel@nongnu.org; Wed, 07 Aug 2019 13:49:36 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:38073) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvQ46-000830-N4 for qemu-devel@nongnu.org; Wed, 07 Aug 2019 13:49:35 -0400 Received: by mail-pl1-x641.google.com with SMTP id m12so3278434plt.5 for ; Wed, 07 Aug 2019 10:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rwTIbhxoEl+9L5Abc76IchYk4TetqSvunhUmVSOtMWo=; b=YSd01dq4KtF6aeZkw5hkDHENoAmzJOdch2P9Xl6k7iJhJOozBH08Xd6X8MdTgN8uFL dayMMbNyz7ZSR+VFJ605dDSnaIApm2E3utOwDPHFZ38Ww0Yq2hW49lnxsZfbp4yn6FDL WbwqPP7yVik0d0cAAsPPdv9U+Jm1KuDYmSkVnREqiqvjtBwIcUnH5Xc/gl9O6lnkIiYk VhL9l6TrN+DQt2wAGnIhc0ENdijp3rUv/YraMyGDu6wMe9x+ZMo7AjxGpCB5GwWDzR8S 4mEFZrxsfoOHb2BNG7md9SL+3ARxa9EvmllUIzDfD4ZcsqQgw4KkThE7J5q6hLkKOjqW ercg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rwTIbhxoEl+9L5Abc76IchYk4TetqSvunhUmVSOtMWo=; b=X1oUIzRH8U6kzJ3mP9VEBjqtIUqRA9nrBrgPnW69GWqqj7nJN93RI/9eGwXsHidR9t tCvFCh02WraJIlbHeC5mEH5QZvpif7OVoUofTTMNJuaHyPpi3rJtfk7kFijBy4W09Exy h4CX2k5gFeaAa+XyRap/XmcbzTK+wr9G5ASygHPYCDcodi8k67xtvak/kualHfwja+vO hluitq07UEx8pYsMh/yx/kfvNC7VvWmV2wB39XD8YGqONPTOJYrwZujPMv63PnbNp1po prPM5hW44NcfDKkXX2NeicwzO+uZfDwnz69J7S17JKSqqNkrkpqGsSwLoE7zfqKAUCNV iO9A== X-Gm-Message-State: APjAAAVj5ytz1PwaAapFiVeDiF+VzcAvfwj3UTxBpHPgOLB3NuBakiqn nmC1xwnXxvqbQHYJPhWvBDS7gQ== X-Google-Smtp-Source: APXvYqxt9kYRUX4/TWB3mOIj77BhJmpABYE2zE095tt7JwCrrSgoc6T05CxabiOshYqLLsydsy93lQ== X-Received: by 2002:a17:902:6b02:: with SMTP id o2mr8483559plk.99.1565200173396; Wed, 07 Aug 2019 10:49:33 -0700 (PDT) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id w1sm489442pjt.30.2019.08.07.10.49.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Aug 2019 10:49:32 -0700 (PDT) To: tony.nguyen@bt.com, qemu-devel@nongnu.org References: <45ec4924e0b34a3d9124e2db06af75b4@tpw09926dag18e.domain1.systemhost.net> <1565166794966.57397@bt.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: <27c692bf-45af-afbe-27ba-1e8f7f936121@linaro.org> Date: Wed, 7 Aug 2019 10:49:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1565166794966.57397@bt.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::641 Subject: Re: [Qemu-devel] [PATCH v6 20/26] memory: Access MemoryRegion with endianness X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, peter.maydell@linaro.org, walling@linux.ibm.com, dmitry.fleytman@gmail.com, imammedo@redhat.com, sagark@eecs.berkeley.edu, david@redhat.com, jasowang@redhat.com, palmer@sifive.com, mark.cave-ayland@ilande.co.uk, laurent@vivier.eu, keith.busch@intel.com, jcmvbkbc@gmail.com, frederic.konrad@adacore.com, pbonzini@redhat.com, kraxel@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, pburton@wavecomp.com, marex@denx.de, robh@kernel.org, hare@suse.com, sstabellini@kernel.org, berto@igalia.com, proljc@gmail.com, qemu-block@nongnu.org, arikalo@wavecomp.com, jslaby@suse.cz, deller@gmx.de, mst@redhat.com, magnus.damm@gmail.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, mreitz@redhat.com, hpoussin@reactos.org, joel@jms.id.au, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, rth@twiddle.net, philmd@redhat.com, green@moxielogic.com, atar4qemu@gmail.com, antonynpavlov@gmail.com, jiri@resnulli.us, ehabkost@redhat.com, minyard@acm.org, sw@weilnetz.de, alistair@alistair23.me, chouteau@adacore.com, b.galvani@gmail.com, eric.auger@redhat.com, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, peter.chubb@nicta.com.au, yuval.shaia@oracle.com, stefanha@redhat.com, marcandre.lureau@redhat.com, shorne@gmail.com, sundeep.lkml@gmail.com, jsnow@redhat.com, david@gibson.dropbear.id.au, kwolf@redhat.com, crwulff@gmail.com, qemu-riscv@nongnu.org, xiaoguangrong.eric@gmail.com, i.mitsyanko@gmail.com, lersek@redhat.com, cohuck@redhat.com, alex.williamson@redhat.com, Andrew.Baumann@microsoft.com, jcd@tribudubois.net, andrew@aj.id.au, michael@walle.cc, paul.durrant@citrix.com, qemu-ppc@nongnu.org, huth@tuxfamily.org, amarkovic@wavecomp.com, kbastian@mail.uni-paderborn.de, jan.kiszka@web.de, stefanb@linux.ibm.com, andrew.smirnov@gmail.com, aurelien@aurel32.net, clg@kaod.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/7/19 1:33 AM, tony.nguyen@bt.com wrote: > @@ -551,6 +551,7 @@ void virtio_address_space_write(VirtIOPCIProxy *proxy, hwaddr addr, > /* As length is under guest control, handle illegal values. */ > return; > } > + /* FIXME: memory_region_dispatch_write ignores MO_BSWAP. */ > memory_region_dispatch_write(mr, addr, val, size_memop(len), > MEMTXATTRS_UNSPECIFIED); > } Here is an example of where Paolo is quite right -- you cannot simply add MO_TE via size_memop(). In patch 22 we see > @@ -542,16 +542,15 @@ void virtio_address_space_write(VirtIOPCIProxy *proxy, hwaddr addr, > val = pci_get_byte(buf); > break; > case 2: > - val = cpu_to_le16(pci_get_word(buf)); > + val = pci_get_word(buf); > break; > case 4: > - val = cpu_to_le32(pci_get_long(buf)); > + val = pci_get_long(buf); > break; > default: > /* As length is under guest control, handle illegal values. */ > return; > } > - /* FIXME: memory_region_dispatch_write ignores MO_BSWAP. */ > memory_region_dispatch_write(mr, addr, val, size_memop(len), > MEMTXATTRS_UNSPECIFIED); This is a little-endian store -- MO_LE not MO_TE. r~