Re: [Qemu-devel] [PATCH v2] hw/bt: drop bluetooth keyboard emulation

[Liam Merwick <liam.merwick@oracle.com>]

On 13/11/2018 11:57, Gerd Hoffmann wrote:
> Broken (segfaults on first keypress, probably since 2.1) and apparently unused.
> 
> Reproducer:
>    qemu -usb -device usb-bt-dongle -bt hci,vlan=0 -bt device:keyboard
> 
> Stacktrace:
>    #0  0x00005606841f7363 in bt_hid_send_data (ch=0x0, type=1, data=0x560686986400 "", len=8)
>        at /home/kraxel/projects/qemu/hw/bt/hid.c:178
>    #1  0x00005606841f7afa in bt_hid_datain (hs=0x560686985eb8)
>        at /home/kraxel/projects/qemu/hw/bt/hid.c:387
>    #2  0x00005606842643d8 in hid_keyboard_event (dev=0x560686985eb8, src=0x5606869b9c10, evt=0x5606868772a0)
>        at /home/kraxel/projects/qemu/hw/input/hid.c:245
>    #3  0x00005606843eab39 in qemu_input_event_send_impl (src=0x5606869b9c10, evt=0x5606868772a0)
>        at /home/kraxel/projects/qemu/ui/input.c:346
>    #4  0x00005606843caadd in replay_input_event (src=0x5606869b9c10, evt=0x5606868772a0)
>        at /home/kraxel/projects/qemu/replay/replay-input.c:128
>    #5  0x00005606843eabf4 in qemu_input_event_send (src=0x5606869b9c10, evt=0x5606868772a0)
>        at /home/kraxel/projects/qemu/ui/input.c:375
>    #6  0x00005606843ead43 in qemu_input_event_send_key (src=0x5606869b9c10, key=0x560686819e50, down=true) at /home/kraxel/projects/qemu/ui/input.c:419
>    #7  0x00005606843eae23 in qemu_input_event_send_key_qcode (src=0x5606869b9c10, q=Q_KEY_CODE_RET, down=true)
>        at /home/kraxel/projects/qemu/ui/input.c:441
>    [ ... snip ... ]
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

One question below, otherwise

Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
Tested-by: Liam Merwick <liam.merwick@oracle.com>

> ---
>   include/hw/bt.h     |   3 -
>   hw/bt/hid.c         | 554 ----------------------------------------------------
>   vl.c                |  34 +---
>   hw/bt/Makefile.objs |   3 +-
>   qemu-doc.texi       |   6 +-
>   qemu-options.hx     |   9 -
>   6 files changed, 3 insertions(+), 606 deletions(-)
>   delete mode 100644 hw/bt/hid.c
> 

[ snip]

> diff --git a/qemu-options.hx b/qemu-options.hx
> index 38c7a978c1..48885cdca8 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx

Is this extra removal needed too?

@@ -2757,9 +2757,7 @@ DEF("bt", HAS_ARG, QEMU_OPTION_bt, \
      "-bt hci[,vlan=n]\n" \
      "                emulate a standard HCI in virtual scatternet 'n'\n" \
      "-bt vhci[,vlan=n]\n" \
-    "                add host computer to virtual scatternet 'n' using 
VHCI\n" \
-    "-bt device:dev[,vlan=n]\n" \
-    "                emulate a bluetooth device 'dev' in scatternet 'n'\n",
+    "                add host computer to virtual scatternet 'n' using 
VHCI\n", \
      QEMU_ARCH_ALL)
  STEXI
  @item -bt hci[...]




> @@ -2804,15 +2804,6 @@ be used as following:
>   qemu-system-i386 [...OPTIONS...] -bt hci,vlan=5 -bt vhci,vlan=5
>   @end example
>   
> -@item -bt device:@var{dev}[,vlan=@var{n}]
> -Emulate a bluetooth device @var{dev} and place it in network @var{n}
> -(default @code{0}).  QEMU can only emulate one type of bluetooth devices
> -currently:
> -
> -@table @option
> -@item keyboard
> -Virtual wireless keyboard implementing the HIDP bluetooth profile.
> -@end table
>   ETEXI
>   
>   STEXI
>