From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 262C1C433F5 for ; Wed, 3 Nov 2021 03:38:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAC12610A8 for ; Wed, 3 Nov 2021 03:38:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BAC12610A8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:39574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mi76Z-0003km-UD for qemu-devel@archiver.kernel.org; Tue, 02 Nov 2021 23:38:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mi75a-0002OU-RF for qemu-devel@nongnu.org; Tue, 02 Nov 2021 23:37:27 -0400 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]:46800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mi75X-0000cH-D7 for qemu-devel@nongnu.org; Tue, 02 Nov 2021 23:37:25 -0400 Received: by mail-qv1-xf2e.google.com with SMTP id g25so1395348qvf.13 for ; Tue, 02 Nov 2021 20:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vqQyj3CJ7mF31+uKoFql/2mn0tOKMJ1bJMz8Zx/Njy4=; b=sAUMClE6L7JQznC+DjqgMxU+1JokKcnbM4Dlns2IhzL8ifZrSWpyTvFGi9//yUELLA 1/qKB+tgcp9BUrLGJj++FsD/0Buap+2dCpWfzQSku8FdIuoXy0CGQ59xvdNEDJzjMjhg rOtR/GPBFW6I8WJMOjoOeWfz+l8cVsTMLI8DsUqwcWODa8mp+mXotzdw4CjjZwDJYnFH 0FGdHrVnEQqmnAhKO7U7YgxJx5iuTSX0YJHvOebjT14cW2s1RXrYTEJKLPeo9F0N6q6R r+5mzdzFwlstpk46djyQYIAdDLQX+YTIAuKllzMPxrToN6rPXtnxP1nNyFcprt5tPxhX ZYXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vqQyj3CJ7mF31+uKoFql/2mn0tOKMJ1bJMz8Zx/Njy4=; b=g/p8LafHDeaeVgRk1JbFJMr+RP17Qj0YfzU7m1FPwkrM9eyJriorje+DxarR09CBxu GLLQfjsNo80JpjOteuiaaAfXvi05oDW5enNkIm2AwDyczXQqB1JD6cey5XhPEpAqpxWu nbRbBeNQljrT7QXDOM42HxNhAsHbghg6O1zHp76DJQTeD9iXXFr+TLqUrMqyi666Ri75 x9m+86fGDC3HVcNnQ9nx/UC/KrY4WF+/Vjamf92LaFgDsh2GXvh2aes67wtT++LvPYOT POEUBqvku3vUSpFziFb5Zd9gFcQ2pPXRQfXAMxdCa9XNgSbKB/FS6L4GWmLTqOyT9K6n jtJw== X-Gm-Message-State: AOAM530FFqWfvoFZSuunozKza2uW8MIyY/52bo/hXo8MOOrTkkzBr7FL oC42n54z/gSfHoGt3PKlBrDPrQ== X-Google-Smtp-Source: ABdhPJwWumPA/+lixIlJgGkiLuIiwsP7hXqaorgMWs1ss/p4PURWF8TdiBQS+TDEUU8HeXwOrEnJdg== X-Received: by 2002:a05:6214:caf:: with SMTP id s15mr22972331qvs.33.1635910641795; Tue, 02 Nov 2021 20:37:21 -0700 (PDT) Received: from [172.20.81.179] (rrcs-172-254-253-57.nyc.biz.rr.com. [172.254.253.57]) by smtp.gmail.com with ESMTPSA id l3sm650558qkj.110.2021.11.02.20.37.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Nov 2021 20:37:21 -0700 (PDT) Subject: Re: [PATCH v2 22/30] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_args To: Warner Losh , qemu-devel@nongnu.org References: <20211102225248.52999-1-imp@bsdimp.com> <20211102225248.52999-23-imp@bsdimp.com> From: Richard Henderson Message-ID: <27eae3b8-156b-540b-e88b-0d8c3097ee7e@linaro.org> Date: Tue, 2 Nov 2021 23:37:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211102225248.52999-23-imp@bsdimp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::f2e; envelope-from=richard.henderson@linaro.org; helo=mail-qv1-xf2e.google.com X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.549, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stacey Son , qemu-trivial@nongnu.org, Kyle Evans , Michael Tokarev , Philippe Mathieu-Daude , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/2/21 6:52 PM, Warner Losh wrote: > + /* > + * Low bit indicates whether or not we're entering thumb mode. > + */ > + cpsr = cpsr_read(env); > + if (ka->_sa_handler & 1) { > + cpsr |= CPSR_T; > + } else { > + cpsr &= ~CPSR_T; > + } > + cpsr_write(env, cpsr, CPSR_T, CPSRWriteByInstr); Like I said before, you don't need the cpsr_read, because the mask ensures that only CPSR_T will change: cpsr_write(env, (ka->_sa_handler & 1) * CPSR_T, CPSR_T, CPSRWriteByInstr); Otherwise, Reviewed-by: Richard Henderson r~