From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: "Marek Vasut" <marex@denx.de>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
qemu-riscv@nongnu.org,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Chris Wulff" <crwulff@gmail.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
qemu-arm@nongnu.org, "Palmer Dabbelt" <palmer@dabbelt.com>,
"Michael Walle" <michael@walle.cc>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v2 10/10] hw/semihosting: Make the feature depend of TCG, and allow to disable it
Date: Thu, 21 May 2020 21:55:33 +0200 [thread overview]
Message-ID: <2810165c-62f9-1cc0-d610-115525d6a06a@redhat.com> (raw)
In-Reply-To: <a67da86e-8486-9fea-ae1c-db65bf5c4acc@linaro.org>
On 5/19/20 11:44 PM, Richard Henderson wrote:
> On 5/15/20 10:08 AM, Philippe Mathieu-Daudé wrote:
>> +++ b/hw/semihosting/Kconfig
>> @@ -1,3 +1,5 @@
>>
>> +# default is 'n'
>> config SEMIHOSTING
>> - bool
>> + bool
>> + depends on TCG
>> diff --git a/target/arm/Kconfig b/target/arm/Kconfig
>> new file mode 100644
>> index 0000000000..3224cac4ad
>> --- /dev/null
>> +++ b/target/arm/Kconfig
>> @@ -0,0 +1,2 @@
>> +config SEMIHOSTING
>> + default y if TCG
>
> Do you really have to duplicate the TCG condition?
How so? The semihosting default table is:
TCG KVM XEN
y n y n y n
TCG y - - y y y y
n - n n n n
KVM y - - n n
n n n
XEN y - -
n -
So checking for TCG is the simpler way.
Maybe I'm not understanding well your question.
The logic is if TCG is selected, SEMIHOSTING is too.
next prev parent reply other threads:[~2020-05-21 19:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 17:07 [PATCH v2 00/10] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
2020-05-15 17:07 ` [PATCH v2 01/10] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-05-17 17:23 ` Thomas Huth
2020-05-15 17:07 ` [PATCH v2 02/10] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-05-17 17:26 ` Thomas Huth
2020-05-21 15:09 ` Philippe Mathieu-Daudé
2020-05-15 17:07 ` [PATCH v2 03/10] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
2020-05-15 17:07 ` [PATCH v2 04/10] accel/tcg: Add stub for probe_access() Philippe Mathieu-Daudé
2020-05-19 21:41 ` Richard Henderson
2020-05-15 17:07 ` [PATCH v2 05/10] Makefile: Remove dangerous EOL trailing backslash Philippe Mathieu-Daudé
2020-05-17 18:00 ` Thomas Huth
2020-05-18 16:46 ` Alistair Francis
2020-05-15 17:08 ` [PATCH v2 06/10] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
2020-05-15 17:08 ` [PATCH v2 07/10] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-05-15 17:08 ` [PATCH v2 08/10] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-05-15 17:08 ` [PATCH v2 09/10] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-05-19 21:42 ` Richard Henderson
2020-05-21 17:33 ` Philippe Mathieu-Daudé
2020-05-15 17:08 ` [PATCH v2 10/10] hw/semihosting: Make the feature depend of TCG, and allow to disable it Philippe Mathieu-Daudé
2020-05-19 21:44 ` Richard Henderson
2020-05-21 19:55 ` Philippe Mathieu-Daudé [this message]
2020-05-16 3:44 ` [PATCH v2 00/10] accel: Allow targets to use Kconfig, disable semihosting by default no-reply
2020-05-16 3:57 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2810165c-62f9-1cc0-d610-115525d6a06a@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=crwulff@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent@vivier.eu \
--cc=marex@denx.de \
--cc=michael@walle.cc \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).