Re: [Qemu-devel] [PATCH 3/3] virtio pmem: remove transational device info

[Pankaj Gupta <pagupta@redhat.com>]

> 
> On 12.07.19 09:35, Pankaj Gupta wrote:
> > Remove transactional & non transactional device info
> > for virtio pmem.
> 
> Can you explain and add *why* ?

As per upstream suggestion by Cornelia & MST, transactional devices are for
legacy purpose. So, does not make sense for virtio-pmem.

Thanks,
Pankaj 

> 
> > 
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> > ---
> >  hw/virtio/virtio-pmem-pci.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virtio-pmem-pci.c
> > index 0da6627469..fe2af00fa1 100644
> > --- a/hw/virtio/virtio-pmem-pci.c
> > +++ b/hw/virtio/virtio-pmem-pci.c
> > @@ -113,8 +113,6 @@ static void virtio_pmem_pci_instance_init(Object *obj)
> >  static const VirtioPCIDeviceTypeInfo virtio_pmem_pci_info = {
> >      .base_name             = TYPE_VIRTIO_PMEM_PCI,
> >      .generic_name          = "virtio-pmem-pci",
> > -    .transitional_name     = "virtio-pmem-pci-transitional",
> > -    .non_transitional_name = "virtio-pmem-pci-non-transitional",
> >      .instance_size = sizeof(VirtIOPMEMPCI),
> >      .instance_init = virtio_pmem_pci_instance_init,
> >      .class_init    = virtio_pmem_pci_class_init,
> > 
> 
> 
> --
> 
> Thanks,
> 
> David / dhildenb
>