From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xvp7O-0005M5-Ia for qemu-devel@nongnu.org; Tue, 02 Dec 2014 10:12:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xvp7J-0004wA-F5 for qemu-devel@nongnu.org; Tue, 02 Dec 2014 10:11:58 -0500 Received: from mx6-phx2.redhat.com ([209.132.183.39]:39832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xvp7I-0004w4-VS for qemu-devel@nongnu.org; Tue, 02 Dec 2014 10:11:53 -0500 Date: Tue, 2 Dec 2014 10:11:29 -0500 (EST) From: Francesco Romani Message-ID: <281933196.5591923.1417533089271.JavaMail.zimbra@redhat.com> In-Reply-To: <20141202150117.GA12390@stefanha-thinkpad.redhat.com> References: <1417177867-27918-1-git-send-email-fromani@redhat.com> <1417177867-27918-2-git-send-email-fromani@redhat.com> <20141202150117.GA12390@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, lcapitulino@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org ----- Original Message ----- > From: "Stefan Hajnoczi" > To: "Francesco Romani" > Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com > Sent: Tuesday, December 2, 2014 4:01:17 PM > Subject: Re: [Qemu-devel] [PATCHv3] block: add event when disk usage exceeds threshold > > On Fri, Nov 28, 2014 at 01:31:07PM +0100, Francesco Romani wrote: > > @@ -82,6 +83,8 @@ BlockDeviceInfo *bdrv_block_device_info(BlockDriverState > > *bs) > > info->iops_size = cfg.op_size; > > } > > > > + info->write_threshold = bdrv_usage_threshold_get(bs); > > Overall looks good but I notice that "write_threshold" and > "usage_threshold" are both used. Please use just one consistently (I > think "write_threshold" is clearer). Agreed. Will use "write_threshold" everywhere, file names included. Bests, -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani