From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC842C3ABB6 for ; Mon, 5 May 2025 09:38:27 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uBsGr-00048K-Ei; Mon, 05 May 2025 05:37:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uBsGp-00047z-Er for qemu-devel@nongnu.org; Mon, 05 May 2025 05:37:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uBsGn-00032T-RM for qemu-devel@nongnu.org; Mon, 05 May 2025 05:37:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746437872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Z7zC9NKcAbLXxorg/N+5PiZtNVXWtneazQuKeOiPbdQ=; b=YF3RqVd/7/TnxB0p6M8xui1/P3OZuuUq+nD+S2ELqhnvgdHMxM8VZh7rB//6okbrAL0nEy d8A6R4ckY2wkwi1oQGSrjUUg8uxQRwdf9WtqM394YRoi39OMgNUI6ldXOOm5Xlut5AYiQh U3lnSmj3WXxN2/BN35VFEgMNoV9V8Fg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-eXNm6t0sPZ6flLtlWm02ug-1; Mon, 05 May 2025 05:37:51 -0400 X-MC-Unique: eXNm6t0sPZ6flLtlWm02ug-1 X-Mimecast-MFC-AGG-ID: eXNm6t0sPZ6flLtlWm02ug_1746437870 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43cf327e9a2so31490885e9.3 for ; Mon, 05 May 2025 02:37:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746437870; x=1747042670; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z7zC9NKcAbLXxorg/N+5PiZtNVXWtneazQuKeOiPbdQ=; b=daQYJUKBFeZ2LGo8zQsXdU7fwwf7Lp8P/dnpC7zpS/HtjYxaZvrtofXWcK7aNVQ0XP 53Fxf/PmMLEO8pDqrVkJl7Wux0V3pFLdBU3ZN/lP88wqAxER5CJl0gQzbR6JxLK2c6HM 6mnPcCYI+nLw3j3BTr5/yeUleRvt702Od/ZTMzit9RTRt4lqk906lbYciP3KIvoMt1Oh tA39lArfqMVSjCdWSz0g1WXrvVn/iFV29fuYAimb8oqtBr8IQQC5Bfy3kRX7HwFk5RCX HzAplX0JfvyzFbTkk/tQmIe5FHf80fu2UAh78VbwaEU1FhPcRy12NJF6Hckmx2Asoxqi G9Aw== X-Forwarded-Encrypted: i=1; AJvYcCV8P9UnK91i8ZKnpZOZEzxqHW1yveaxlrTgRvTKTlyJXoySM8nTrqGT57L0k8so/UdLbmm44nRbKmZz@nongnu.org X-Gm-Message-State: AOJu0YyfG8BkZNRDGcpkLR/uknLihbexKPv6I3Exu4jrfYZfxCC19ugt 54GdmTcz60AAew2IYwnMda9v6MsypkygBseWVhC5/UHYPtj3sLkAFFnPKjZp2vYqybSSFRnmPxG tmqMyE9HtqOJI5q1nTu+osIFlpJQskWepSHWRIhsVYkOxoTrPajnV X-Gm-Gg: ASbGncveSLNw4GPaapQYwBSlDeKUdbgKKgzb+RMR5GXDMuJsPyyqYWqZktVO8MfJxMI yCK10oLblkZ5uF7eg2IRk9nzhBWOA4AKaZBkwhLlRnFOCw0afw43J/O9noWt5ZxVUbXibjZ0kIg Seue1KroeyD7mivlYvZzEt1eGyPOxYBAY9JxZzpHy9Ddo4TSk0D+k3oURRwXWdExNgS14boJ23k mzEUwSJ4CYq01uhYQxbZ/nIXmjrsTRmlJlHVkgp9g0DnzuOOAkVu2RIQC/Tq+YxGQLCuRJOyr/X Kxnt+J8WhAfI5vFH2+1sIXy10M6hETLIct5NndbIFo9+x7T5lg== X-Received: by 2002:a05:600c:cce:b0:43d:fa59:af98 with SMTP id 5b1f17b1804b1-441c1d73dfcmr61008315e9.33.1746437870194; Mon, 05 May 2025 02:37:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsxP0M7lCcatE1Q1DmkMULWx4JTyf1G3KrzYKAM1vPEs9njhIossuGOkovubhBQUDOOTxUVw== X-Received: by 2002:a05:600c:cce:b0:43d:fa59:af98 with SMTP id 5b1f17b1804b1-441c1d73dfcmr61008105e9.33.1746437869815; Mon, 05 May 2025 02:37:49 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2af32a0sm175744665e9.23.2025.05.05.02.37.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 02:37:49 -0700 (PDT) Message-ID: <2834ac16-5c5b-4855-aa64-64a5d0b034c3@redhat.com> Date: Mon, 5 May 2025 11:37:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/15] include/qemu: add strread/writeerror() To: John Levon , qemu-devel@nongnu.org Cc: Peter Xu , qemu-s390x@nongnu.org, Jason Herne , Tomita Moeko , Markus Armbruster , Matthew Rosato , Eric Farman , David Hildenbrand , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" , Tony Krowiak , Alex Williamson , Stefano Garzarella , Thomas Huth , Paolo Bonzini , Halil Pasic References: <20250430194003.2793823-1-john.levon@nutanix.com> <20250430194003.2793823-7-john.levon@nutanix.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20250430194003.2793823-7-john.levon@nutanix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.411, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/30/25 21:39, John Levon wrote: > Add simple helpers to correctly report failures from read/write routines > using the return -errno style. I would keep these helpers under vfio for the moment. Their use is a bit context-specific and making them common requires more work, which would likely make them less useful. Thanks, C. > Signed-off-by: John Levon > --- > include/qemu/error-report.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h > index 3ae2357fda..67afe5a020 100644 > --- a/include/qemu/error-report.h > +++ b/include/qemu/error-report.h > @@ -70,6 +70,20 @@ void error_init(const char *argv0); > fmt, ##__VA_ARGS__); \ > }) > > +/* > + * Given a return value of either a short number of bytes read or -errno, > + * construct a meaningful error message. > + */ > +#define strreaderror(ret) \ > + (ret < 0 ? strerror(-ret) : "short read") > + > +/* > + * Given a return value of either a short number of bytes written or -errno, > + * construct a meaningful error message. > + */ > +#define strwriteerror(ret) \ > + (ret < 0 ? strerror(-ret) : "short write") > + > extern bool message_with_timestamp; > extern bool error_with_guestname; > extern const char *error_guest_name;