From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJ83K-0003Aw-UN for qemu-devel@nongnu.org; Fri, 01 Jul 2016 19:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJ83F-0000A3-Vi for qemu-devel@nongnu.org; Fri, 01 Jul 2016 19:40:53 -0400 Received: from mail-qk0-x230.google.com ([2607:f8b0:400d:c09::230]:34472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJ83F-00009M-RS for qemu-devel@nongnu.org; Fri, 01 Jul 2016 19:40:49 -0400 Received: by mail-qk0-x230.google.com with SMTP id t127so227109815qkf.1 for ; Fri, 01 Jul 2016 16:40:49 -0700 (PDT) Sender: Richard Henderson References: <1464986428-6739-1-git-send-email-alex.bennee@linaro.org> <1464986428-6739-9-git-send-email-alex.bennee@linaro.org> From: Richard Henderson Message-ID: <2836eb22-49ce-b43e-dbd8-7a5ed873593f@twiddle.net> Date: Fri, 1 Jul 2016 16:40:45 -0700 MIME-Version: 1.0 In-Reply-To: <1464986428-6739-9-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC v3 08/19] tcg: protect TBContext with tb_lock. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , mttcg@greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, serge.fdrv@gmail.com, cota@braap.org, bobby.prani@gmail.com Cc: mark.burton@greensocs.com, pbonzini@redhat.com, jan.kiszka@siemens.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite , Eduardo Habkost , "Michael S. Tsirkin" On 06/03/2016 01:40 PM, Alex Bennée wrote: > From: KONRAD Frederic > > This protects TBContext with tb_lock to make tb_* thread safe. > > We can still have issue with tb_flush in case of multithread TCG: > another CPU can be executing code during a flush. > > This can be fixed later by making all other TCG thread exiting before calling > tb_flush(). > > Signed-off-by: KONRAD Frederic > Message-Id: <1439220437-23957-8-git-send-email-fred.konrad@greensocs.com> > Signed-off-by: Emilio G. Cota > Signed-off-by: Paolo Bonzini > [AJB: moved into tree, clean-up history] > Signed-off-by: Alex Bennée > > --- Reviewed-by: Richard Henderson r~