From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Fam Zheng" <fam@euphon.net>,
S.E.Harris@kent.ac.uk,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
me@xcancerberox.com.ar, qemu-devel@nongnu.org,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Markus Armbruster" <armbru@redhat.com>,
dovgaluk@ispras.ru,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
aleksandar.m.mail@gmail.com,
"Laurent Vivier" <lvivier@redhat.com>,
thuth@redhat.com, "Eduardo Habkost" <ehabkost@redhat.com>,
richard.henderson@linaro.org, mrolnik@gmail.com,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-riscv@nongnu.org,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
imammedo@redhat.com
Subject: Re: [PATCH rc2 12/25] hw/timer: Add limited support for Atmel 16 bit timer peripheral
Date: Fri, 24 Jan 2020 13:52:55 +0100 [thread overview]
Message-ID: <28386847-9b49-2be7-a6df-f6ce030855ec@redhat.com> (raw)
In-Reply-To: <875zh1yw38.fsf@linaro.org>
On 1/24/20 11:42 AM, Alex Bennée wrote:
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>
>> From: Michael Rolnik <mrolnik@gmail.com>
>>
>> These were designed to facilitate testing but should provide enough
>> function to be useful in other contexts. Only a subset of the functions
>> of each peripheral is implemented, mainly due to the lack of a standard
>> way to handle electrical connections (like GPIO pins).
>>
>> Signed-off-by: Sarah Harris <S.E.Harris@kent.ac.uk>
>> Message-Id: <20200118191416.19934-13-mrolnik@gmail.com>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> [rth: Squash info mtree fixes and a file rename from f4bug, which was:]
>> Suggested-by: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> [PMD: Use qemu_log_mask(LOG_UNIMP), replace goto by return]
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
<snip>
>> --- /dev/null
>> +++ b/hw/timer/atmel_timer16.c
>> @@ -0,0 +1,605 @@
> <snip>
>> +
>> +/* Helper macros */
>> +#define VAL16(l, h) ((h << 8) | l)
>> +#define DB_PRINT(fmt, args...) /* Nothing */
>> +/*#define DB_PRINT(fmt, args...) printf("%s: " fmt "\n", __func__, ##
>> args)*/
>
> Format strings are likely to bitrot. Either use a if (GATE) or
> tracepoints.
To avoid respining, I'll do in a new a patch on top of this series,
and Richard can choose to squash it directly.
> <snip>
>
> Otherwise:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
next prev parent reply other threads:[~2020-01-24 12:53 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 0:51 [PATCH rc2 00/25] target/avr merger Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 01/25] target/avr: Add outward facing interfaces and core CPU logic Philippe Mathieu-Daudé
2020-01-25 10:48 ` Aleksandar Markovic
2020-01-25 17:08 ` Thomas Huth
2020-01-26 12:15 ` Joaquin de Andres
2020-01-27 2:25 ` Aleksandar Markovic
2020-01-27 8:53 ` Michael Rolnik
2020-01-27 9:24 ` Joaquin de Andres
2020-01-27 9:48 ` Michael Rolnik
2020-01-27 10:39 ` Joaquin de Andres
2020-01-27 13:27 ` Joaquin de Andres
2020-01-27 13:38 ` Michael Rolnik
2020-01-31 1:22 ` Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 02/25] target/avr: Add instruction helpers Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 03/25] target/avr: Add instruction translation - Registers definition Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 04/25] target/avr: Add instruction translation - Arithmetic and Logic Instructions Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 05/25] target/avr: Add instruction translation - Branch Instructions Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 06/25] target/avr: Add instruction translation - Data Transfer Instructions Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 07/25] target/avr: Add instruction translation - Bit and Bit-test Instructions Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 08/25] target/avr: Add instruction translation - MCU Control Instructions Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 09/25] target/avr: Add instruction translation - CPU main translation function Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 10/25] target/avr: Add instruction disassembly function Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 11/25] hw/char: Add limited support for Atmel USART peripheral Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 12/25] hw/timer: Add limited support for Atmel 16 bit timer peripheral Philippe Mathieu-Daudé
2020-01-24 8:16 ` Thomas Huth
2020-01-24 12:50 ` Philippe Mathieu-Daudé
2020-01-30 22:45 ` Aleksandar Markovic
2020-01-24 10:42 ` Alex Bennée
2020-01-24 10:51 ` Philippe Mathieu-Daudé
2020-01-24 12:07 ` Sarah Harris
2020-01-30 22:44 ` Aleksandar Markovic
2020-01-31 11:20 ` Philippe Mathieu-Daudé
2020-01-24 12:52 ` Philippe Mathieu-Daudé [this message]
2020-01-24 0:51 ` [PATCH rc2 13/25] hw/misc: Add Atmel power device Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 14/25] target/avr: Add section about AVR into QEMU documentation Philippe Mathieu-Daudé
2020-01-24 7:14 ` Thomas Huth
2020-01-24 11:50 ` Michael Rolnik
2020-01-24 0:51 ` [PATCH rc2 15/25] target/avr: Register AVR support with the rest of QEMU Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 16/25] target/avr: Add machine none test Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 17/25] target/avr: Update MAINTAINERS file Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 18/25] hw/core/loader: Let load_elf populate the processor-specific flags Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 19/25] hw/avr: Add helper to load raw/ELF firmware binaries Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 20/25] hw/avr: Add some ATmega microcontrollers Philippe Mathieu-Daudé
2020-01-26 14:46 ` Aleksandar Markovic
2020-01-27 7:59 ` Philippe Mathieu-Daudé
2020-01-27 8:04 ` Aleksandar Markovic
2020-01-24 0:51 ` [PATCH rc2 21/25] hw/avr: Add some Arduino boards Philippe Mathieu-Daudé
2020-01-25 9:32 ` Joaquin de Andres
2020-01-24 0:51 ` [PATCH rc2 22/25] target/avr: Update build system Philippe Mathieu-Daudé
2020-01-24 10:59 ` Alex Bennée
2020-01-24 0:51 ` [PATCH rc2 23/25] tests/boot-serial-test: Test some Arduino boards (AVR based) Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 24/25] tests/acceptance: Test the Arduino MEGA2560 board Philippe Mathieu-Daudé
2020-01-24 0:51 ` [PATCH rc2 25/25] .travis.yml: Run the AVR acceptance tests Philippe Mathieu-Daudé
2020-01-24 1:02 ` [PATCH rc2 00/25] target/avr merger Philippe Mathieu-Daudé
2020-01-24 7:12 ` Thomas Huth
2020-01-24 11:41 ` Michael Rolnik
2020-01-24 12:49 ` Philippe Mathieu-Daudé
2020-01-24 14:11 ` Michael Rolnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28386847-9b49-2be7-a6df-f6ce030855ec@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=S.E.Harris@kent.ac.uk \
--cc=aleksandar.m.mail@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=imammedo@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=me@xcancerberox.com.ar \
--cc=mrolnik@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sagark@eecs.berkeley.edu \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).