From: yong.huang@smartx.com
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,
Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
yong.huang@smartx.com
Subject: [PATCH v4 4/6] migration: Remove "rs" parameter in migration_bitmap_sync_precopy
Date: Thu, 17 Oct 2024 14:42:53 +0800 [thread overview]
Message-ID: <283c335d61463bf477160da91b24da45cdaf3e43.1729146786.git.yong.huang@smartx.com> (raw)
In-Reply-To: <cover.1729146786.git.yong.huang@smartx.com>
From: Hyman Huang <yong.huang@smartx.com>
The global static variable ram_state in fact is referred to by the
"rs" parameter in migration_bitmap_sync_precopy. For ease of calling
by the callees, use the global variable directly in
migration_bitmap_sync_precopy and remove "rs" parameter.
The migration_bitmap_sync_precopy will be exported in the next commit.
Signed-off-by: Hyman Huang <yong.huang@smartx.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
migration/ram.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 54d352b152..9b5b350405 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1088,9 +1088,10 @@ static void migration_bitmap_sync(RAMState *rs, bool last_stage)
}
}
-static void migration_bitmap_sync_precopy(RAMState *rs, bool last_stage)
+static void migration_bitmap_sync_precopy(bool last_stage)
{
Error *local_err = NULL;
+ assert(ram_state);
/*
* The current notifier usage is just an optimization to migration, so we
@@ -1101,7 +1102,7 @@ static void migration_bitmap_sync_precopy(RAMState *rs, bool last_stage)
local_err = NULL;
}
- migration_bitmap_sync(rs, last_stage);
+ migration_bitmap_sync(ram_state, last_stage);
if (precopy_notify(PRECOPY_NOTIFY_AFTER_BITMAP_SYNC, &local_err)) {
error_report_err(local_err);
@@ -2782,7 +2783,7 @@ static bool ram_init_bitmaps(RAMState *rs, Error **errp)
if (!ret) {
goto out_unlock;
}
- migration_bitmap_sync_precopy(rs, false);
+ migration_bitmap_sync_precopy(false);
}
}
out_unlock:
@@ -3248,7 +3249,7 @@ static int ram_save_complete(QEMUFile *f, void *opaque)
WITH_RCU_READ_LOCK_GUARD() {
if (!migration_in_postcopy()) {
- migration_bitmap_sync_precopy(rs, true);
+ migration_bitmap_sync_precopy(true);
}
ret = rdma_registration_start(f, RAM_CONTROL_FINISH);
@@ -3330,7 +3331,7 @@ static void ram_state_pending_exact(void *opaque, uint64_t *must_precopy,
if (!migration_in_postcopy()) {
bql_lock();
WITH_RCU_READ_LOCK_GUARD() {
- migration_bitmap_sync_precopy(rs, false);
+ migration_bitmap_sync_precopy(false);
}
bql_unlock();
}
--
2.27.0
next prev parent reply other threads:[~2024-10-17 6:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 6:42 [PATCH v4 0/6] migration: auto-converge refinements for huge VM yong.huang
2024-10-17 6:42 ` [PATCH v4 1/6] accel/tcg/icount-common: Remove the reference to the unused header file yong.huang
2024-10-17 17:59 ` Fabiano Rosas
2024-10-17 6:42 ` [PATCH v4 2/6] migration: Stop CPU throttling conditionally yong.huang
2024-10-17 18:02 ` Fabiano Rosas
2024-10-17 6:42 ` [PATCH v4 3/6] migration: Move cpu-throttole.c from system to migration yong.huang
2024-10-17 18:10 ` Fabiano Rosas
2024-10-17 6:42 ` yong.huang [this message]
2024-10-17 6:42 ` [PATCH v4 5/6] migration: Support periodic RAMBlock dirty bitmap sync yong.huang
2024-10-17 18:57 ` Fabiano Rosas
2024-10-17 19:33 ` Peter Xu
2024-10-17 20:35 ` Fabiano Rosas
2024-10-18 1:55 ` Yong Huang
2024-10-17 6:42 ` [PATCH v4 6/6] tests/migration: Add case for periodic ramblock dirty sync yong.huang
2024-10-17 19:01 ` Fabiano Rosas
2024-10-18 15:08 ` [PATCH v4 0/6] migration: auto-converge refinements for huge VM Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=283c335d61463bf477160da91b24da45cdaf3e43.1729146786.git.yong.huang@smartx.com \
--to=yong.huang@smartx.com \
--cc=farosas@suse.de \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).