From: Richard Henderson <richard.henderson@linaro.org>
To: Bibo Mao <maobibo@loongson.cn>, Song Gao <gaosong@loongson.cn>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/5] target/loongarch: Set function loongarch_cpu_has_work() as public
Date: Mon, 22 Sep 2025 07:27:26 -0700 [thread overview]
Message-ID: <284089de-899c-40d6-b154-dfbfa699c387@linaro.org> (raw)
In-Reply-To: <20250922073400.1308169-3-maobibo@loongson.cn>
On 9/22/25 00:33, Bibo Mao wrote:
> --- a/target/loongarch/cpu.h
> +++ b/target/loongarch/cpu.h
> @@ -478,6 +478,9 @@ static inline void set_pc(CPULoongArchState *env, uint64_t value)
> }
> }
>
> +bool loongarch_cpu_has_work(CPUState *cs);
> +bool cpu_loongarch_hw_interrupts_pending(CPULoongArchState *env);
> +
> /*
> * LoongArch CPUs hardware flags.
> */
Better to declare these in internals.h. Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2025-09-22 14:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 7:33 [PATCH 0/5] target/loongarch: Move TCG specified functions to tcg_cpu.c Bibo Mao
2025-09-22 7:33 ` [PATCH 1/5] " Bibo Mao
2025-09-22 7:33 ` [PATCH 2/5] target/loongarch: Set function loongarch_cpu_has_work() as public Bibo Mao
2025-09-22 14:27 ` Richard Henderson [this message]
2025-09-22 7:33 ` [PATCH 3/5] target/loongarch: Set file tcg_cpu.c separate from cpu.c Bibo Mao
2025-09-22 14:29 ` Richard Henderson
2025-09-23 2:41 ` Bibo Mao
2025-09-22 7:33 ` [PATCH 4/5] target/loongarch: Move function do_raise_exception() to tcg_cpu.c Bibo Mao
2025-09-22 14:32 ` Richard Henderson
2025-09-22 7:34 ` [PATCH 5/5] target/loongarch: Define loongarch_exception_name() as static Bibo Mao
2025-09-22 14:32 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=284089de-899c-40d6-b154-dfbfa699c387@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gaosong@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=maobibo@loongson.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).