qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luis Machado <luis.machado@arm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Fabiano Rosas" <farosas@suse.de>,
	qemu-devel@nongnu.org, "David Hildenbrand" <david@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-arm@nongnu.org, "Peter Xu" <peterx@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>, gdb <gdb@gnu.org>,
	"Thiago Jung Bauermann" <thiago.bauermann@linaro.org>,
	"Omair Javaid" <omair.javaid@linaro.org>
Subject: Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests
Date: Fri, 17 Mar 2023 17:12:48 +0000	[thread overview]
Message-ID: <284bbdeb-f68c-a0fb-4bec-e000eeef771f@arm.com> (raw)
In-Reply-To: <CAFEAcA8gDqrg3Hjv=0P-6m-bHytoHrYRSrrY1anu3gGZuQaL1Q@mail.gmail.com>

On 3/17/23 17:07, Peter Maydell wrote:
> On Fri, 17 Mar 2023 at 16:55, Luis Machado <luis.machado@arm.com> wrote:
>> On 3/17/23 16:37, Peter Maydell wrote:
>>> Having run into this problem in another couple of situations, one of
>>> which involved gdb 10, I think I'm increasingly favouring option
>>> 2 here. The affected gdbs seem to be quite widely deployed, and
>>> the bug results in crashes even for users who didn't really
>>> care about pauth. So I'd rather we didn't release a QEMU 8.0
>>> which crashes these affected deployed gdbs.
>>>
>>
>> Are the affected gdb's packaged by distros? If so, a backport the distros can pick up
>> will solve this in a quick package update.
>
> Yes, it's exactly because these gdbs are distro-packaged
> that I don't want QEMU to make them crash. I think it's
> going to take a long time for the fix to go into gdb branches
> and gdb to make a point release and distros to pick up that
> point release, and in the meantime that's a lot of crashing
> gdb bug reports that we're going to have to field.

Just to clarify, there won't be any point releases for gdb's 9/10/11/12.  We might have a bug fix
release for gdb 13 though (which isn't affected).

>
>> If we decide qemu should now emit a different xml for pauth, it will fix the crashes, but it also
>> means older gdb's (9/10/11/12) will not be able to backtrace properly through pauth-signed frames.
>>
>> Maybe that's a reasonable drawback for qemu users?
>
> "No backtrace through pauth frames" is the situation we've
> been in ever since we implemented pauth in 2019, so I think
> that's fine. It's not regressing something that used to work.
>

Fair enough.

>> If someone decides to implement a debugging stub that reports pauth (fast models, for example), it will
>> also crash gdb, so I still plan to do the backport anyway.
>
> If you're backporting the fix, you could also backport the
> (hopefully tiny) change that says "treat pauth_v2 the same
> way we do pauth", and then users with an updated older
> gdb will also get working backtraces.

I can negotiate that as well, though it borders being a new feature.

>
> thanks
> -- PMM

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


  reply	other threads:[~2023-03-17 17:14 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 10:31 [PATCH 00/11] tweaks and fixes for 8.0-rc1 (tests, plugins, docs) Alex Bennée
2023-03-10 10:31 ` [PATCH 01/11] tests/avocado: update AArch64 tests to Alpine 3.17.2 Alex Bennée
2023-03-10 10:31 ` [PATCH 02/11] tests/docker: all add DOCKER_BUILDKIT to RUNC environment Alex Bennée
2023-03-10 10:31 ` [PATCH 03/11] scripts/ci: add libslirp-devel to build-environment Alex Bennée
2023-03-10 10:31 ` [PATCH 04/11] scripts/ci: update gitlab-runner playbook to handle CentOS Alex Bennée
2023-03-10 10:31 ` [PATCH 05/11] gitlab: update centos-8-stream job Alex Bennée
2023-03-10 10:31 ` [PATCH 06/11] include/qemu: add documentation for memory callbacks Alex Bennée
2023-03-10 10:31 ` [PATCH 07/11] tcg: Clear plugin_mem_cbs on TB exit Alex Bennée
2023-03-10 17:39   ` Richard Henderson
2023-03-10 17:41     ` Richard Henderson
2023-03-10 17:56       ` Alex Bennée
2023-03-10 17:59         ` Richard Henderson
2023-03-10 10:31 ` [PATCH 08/11] tests/tcg: add some help output for running individual tests Alex Bennée
2023-03-10 10:31 ` [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests Alex Bennée
2023-03-10 17:44   ` Richard Henderson
2023-03-10 17:47   ` Peter Maydell
2023-03-10 18:00     ` Fabiano Rosas
2023-03-10 18:07       ` Peter Maydell
2023-03-10 18:15         ` Fabiano Rosas
2023-03-13 11:16         ` Luis Machado
2023-03-10 18:14       ` Alex Bennée
2023-03-13 11:22         ` Peter Maydell
2023-03-13 11:44           ` Luis Machado
2023-03-13 19:21             ` Richard Henderson
2023-03-13 21:35               ` Peter Maydell
2023-03-14  8:20               ` Luis Machado
2023-03-15  9:50             ` Luis Machado
2023-03-17 16:37               ` Peter Maydell
2023-03-17 16:55                 ` Luis Machado
2023-03-17 17:07                   ` Peter Maydell
2023-03-17 17:12                     ` Luis Machado [this message]
2023-03-17 17:16                       ` Luis Machado
2023-03-10 18:07     ` Richard Henderson
2023-03-10 10:31 ` [PATCH 10/11] include/exec: fix kerneldoc definition Alex Bennée
2023-03-10 12:38   ` Philippe Mathieu-Daudé
2023-03-13 17:00   ` Thomas Huth
2023-03-13 17:03     ` Peter Maydell
2023-03-13 17:14       ` Thomas Huth
2023-03-13 17:30         ` Peter Maydell
2023-03-13 18:08           ` Peter Maydell
2023-03-10 10:31 ` [PATCH 11/11] tests/avocado: don't use tags to define drive Alex Bennée
2023-03-10 11:04   ` David Woodhouse
2023-03-10 12:42   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=284bbdeb-f68c-a0fb-4bec-e000eeef771f@arm.com \
    --to=luis.machado@arm.com \
    --cc=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=david@redhat.com \
    --cc=farosas@suse.de \
    --cc=gdb@gnu.org \
    --cc=omair.javaid@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thiago.bauermann@linaro.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).