From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 935FAC83000 for ; Thu, 30 Apr 2020 14:22:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A788206D9 for ; Thu, 30 Apr 2020 14:22:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hkYRgjUs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A788206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUA5R-0005f4-IF for qemu-devel@archiver.kernel.org; Thu, 30 Apr 2020 10:22:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57996) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU9xu-0001nL-VL for qemu-devel@nongnu.org; Thu, 30 Apr 2020 10:15:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jU9xt-0006PQ-69 for qemu-devel@nongnu.org; Thu, 30 Apr 2020 10:15:02 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:31342 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jU9xr-0006ON-5d for qemu-devel@nongnu.org; Thu, 30 Apr 2020 10:15:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588256096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w0WFTxVECvqas2wznFqihz67PoCXsfs4eoJFQUxENys=; b=hkYRgjUsBCjPk1i8/OT1IY/hNTzoAJ1vrV6VF/TmY+nEsyxZjz+g0LkstPA7A17EZQcyUe bjF8FXCK3HI+fHb+Dgo3XZDZelggyOOyocaLBM6SZnnV0nuX0hLGa5aRhX/Q4B63YDftFN gAi9/SLQ4anODORM6+oqdfq7ma96tuY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-393-TxqYLBCDON-WRUifK1woMA-1; Thu, 30 Apr 2020 10:14:54 -0400 X-MC-Unique: TxqYLBCDON-WRUifK1woMA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ADA6E1005510; Thu, 30 Apr 2020 14:14:53 +0000 (UTC) Received: from [10.10.116.80] (ovpn-116-80.rdu2.redhat.com [10.10.116.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C005C5C1B0; Thu, 30 Apr 2020 14:14:52 +0000 (UTC) Subject: Re: [PATCH 2/6] vmdk: Fix zero cluster allocation To: Kevin Wolf , qemu-block@nongnu.org References: <20200430133007.170335-1-kwolf@redhat.com> <20200430133007.170335-3-kwolf@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <284fd945-2080-1fc8-3f92-3f276184eceb@redhat.com> Date: Thu, 30 Apr 2020 09:14:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200430133007.170335-3-kwolf@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/29 23:34:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/30/20 8:30 AM, Kevin Wolf wrote: > m_data must be contain valid data even for zero clusters when no cluster s/be // > was allocated in the image file. Without this, zero writes segfault with > images that have zeroed_grain=on. > > For zero writes, we don't want to allocate a cluster in the image file > even in compressed files. > > Fixes: 524089bce43fd1cd3daaca979872451efa2cf7c6 Nearly 4 years ago, and claims to fix a different regression. Wow, we aren't doing too well with vmdk. > Signed-off-by: Kevin Wolf > --- > block/vmdk.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org