Re: [PATCH 0/7] testing/next (qtest timer stuff)

[Thomas Huth <thuth@redhat.com>]

On 20/01/2025 22.02, Alex Bennée wrote:
> Hi,
> 
> Thomas found that a number of tests fail under CFI and other exotic
> setups. The eventual realisation was that --enable-slirp masks a lot
> of timer misuse because it ensures there is always a timer and
> therefor things tend to move on (until the system is shutting down).
> 
> It turns out that bc02be4508 wasn't the solution after all. The first
> few patches are clean-ups and various tightening of test expectations
> before we revert the patch.
> 
> Please review:
> 
>    Revert "util/timer: avoid deadlock when shutting down"
>    tests/qtest: tighten up the checks on clock_step
>    tests/qtest: rename qtest_send_prefix and roll-up into qtest_send
>    tests/qtest: simplify qtest_process_inbuf
>    tests/qtest: don't step clock at start of npcm7xx periodic IRQ test
>    tests/qtest: don't attempt to clock_step while waiting for virtio ISR
>    tests/docker: replicate the check-rust-tools-nightly CI job
> 
> Alex.
> 
> Alex Bennée (7):
>    tests/docker: replicate the check-rust-tools-nightly CI job
>    tests/qtest: don't attempt to clock_step while waiting for virtio ISR
>    tests/qtest: don't step clock at start of npcm7xx periodic IRQ test
>    tests/qtest: simplify qtest_process_inbuf
>    tests/qtest: rename qtest_send_prefix and roll-up into qtest_send
>    tests/qtest: tighten up the checks on clock_step
>    Revert "util/timer: avoid deadlock when shutting down"

Thanks, I've checked that this fixes the check-cfi-* CI jobs and it also 
seems to help with the travis jobs that use --disable-slirp:

  https://app.travis-ci.com/github/huth/qemu/builds/273921493

Tested-by: Thomas Huth <thuth@redhat.com>