From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, hreitz@redhat.com, dave@treblig.org,
qemu-block@nongnu.org, berrange@redhat.com, dgilbert@redhat.com,
qemu-trivial@nongnu.org
Subject: Re: [PATCH 1/2] docs tests: Fix use of migrate_set_parameter
Date: Fri, 25 Aug 2023 18:13:54 +0200 [thread overview]
Message-ID: <2859aebf-f2a3-1c19-b5c3-efbd1ae14977@redhat.com> (raw)
In-Reply-To: <20230825155923.1983141-2-armbru@redhat.com>
On 25/08/2023 17.59, Markus Armbruster wrote:
> docs/multi-thread-compression.txt uses parameter names with
> underscores instead of dashes. Wrong since day one.
>
> docs/rdma.txt, tests/qemu-iotests/181, and tests/qtest/test-hmp.c are
> wrong the same way since commit cbde7be900d2 (v6.0.0). Hard to see,
> as test-hmp doesn't check whether the commands work, and iotest 181
> appears to be unaffected.
>
> Fixes: 263170e679df (docs: Add a doc about multiple thread compression)
> Fixes: cbde7be900d2 (migrate: remove QMP/HMP commands for speed, downtime and cache size)
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-08-25 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 15:59 [PATCH 0/2] docs tests: Fix use of migrate_set_parameter Markus Armbruster
2023-08-25 15:59 ` [PATCH 1/2] " Markus Armbruster
2023-08-25 16:13 ` Thomas Huth [this message]
2023-08-25 15:59 ` [PATCH 2/2] tests/qtest/test-hmp: Fix migrate_set_parameter xbzrle-cache-size test Markus Armbruster
2023-08-25 16:09 ` Thomas Huth
2023-08-29 17:37 ` [PATCH 0/2] docs tests: Fix use of migrate_set_parameter Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2859aebf-f2a3-1c19-b5c3-efbd1ae14977@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dave@treblig.org \
--cc=dgilbert@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).