From: John Snow <jsnow@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: -enablefips
Date: Wed, 24 Jun 2020 11:09:33 -0400 [thread overview]
Message-ID: <285d9cac-4fd8-76ff-a491-9424e4e924fe@redhat.com> (raw)
In-Reply-To: <20200624064954.jmkqonjbqfhso5dr@sirius.home.kraxel.org>
On 6/24/20 2:49 AM, Gerd Hoffmann wrote:
> IIRC the idea is to have a global switch to enable fips compilance for
> the whole distro. RH specific. rhel-7 kernel has it. rhel-8 kernel
> too, so it probably isn't obsolete. Not present in mainline kernels.
>
> I'm wondering what the point of the -enablefips switch is. Shouldn't
> qemu check /proc/sys/crypto/fips_enabled unconditionally instead?
It sounds like we want a compile-time flag that makes it mandatory
instead of optional where it doesn't do a good job of "enforcing" fips
mode. (If you accidentally, uh, omit it.)
Then the flag can go away. Compile the feature in or out. Toggle the
behavior using the /proc/sys/ flag.
Or, as Dan said, just get rid of it. It sounds like it's already handled
by our client libraries in 2020.
--js
next prev parent reply other threads:[~2020-06-24 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 3:51 -enablefips John Snow
2020-06-24 6:49 ` -enablefips Gerd Hoffmann
2020-06-24 8:34 ` -enablefips Markus Armbruster
2020-06-24 8:58 ` -enablefips Daniel P. Berrangé
2020-06-24 15:09 ` John Snow [this message]
2020-06-24 9:05 ` -enablefips Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=285d9cac-4fd8-76ff-a491-9424e4e924fe@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).