Re: [Qemu-devel] [PATCH V7 1/4] rules: Move cross compilation auto detection functions to rules.mak

[Laurent Vivier <lvivier@redhat.com>]

On 05/03/2018 18:59, Wei Huang wrote:
...
> 
> SLO build actually is OK if we don't move the cross-compile stuff to the
> generic rules.mak.
> 
> So this cross-compile approach has lots of objection (unclean, broken
> rom build etc.). A complete solution will make this patchset bloated,
> which is diverted away from original purpose of migration-test.
> 
> Dave & Drew: will the following be acceptable?
> 
> 1. Still use Makefile for .s->.h compilation
> 2. In Makefile, we don't support cross-compilation. This avoids
> duplicating the cross-compile detection code at all. Whoever really
> wants to re-generate .h file must be avid programmers. They can either
> find a native machine or fix Makefile themselves.
> 3. The cross-compile re-factoring will become a separate patchset. In
> that patchset, both ROM and migration-test Makefiles will be changed to
> support cross compilation.
> 
> Thoughts?

I agree with Peter: I think an improvement would be to detect/configure
cross-compilers at the configure level, not in the Makefile.

thanks,
Laurent