qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: shiliyang <shiliyang@huawei.com>,
	richard.henderson@linaro.org, pbonzini@redhat.com,
	philmd@redhat.com, alex.bennee@linaro.org, laurent@vivier.eu
Cc: alex.chen@huawei.com, hunongda@huawei.com,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/4] bsd-user: space required after semicolon
Date: Wed, 4 Nov 2020 12:08:24 +0100	[thread overview]
Message-ID: <28961057-f570-a203-e098-6ec0d5be3f75@redhat.com> (raw)
In-Reply-To: <b7231b6c-97ad-5b4c-0932-08fa331dbb30@huawei.com>

On 04/11/2020 11.20, shiliyang wrote:
> This patch fixes error style problems found by checkpatch.pl:
> ERROR: space required after that ';'
> 
> Signed-off-by: Liyang Shi <shiliyang@huawei.com>
> 
> ---
>  bsd-user/elfload.c | 2 +-
>  bsd-user/syscall.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c
> index 9f4210af9a..25e625d86b 100644
> --- a/bsd-user/elfload.c
> +++ b/bsd-user/elfload.c
> @@ -1227,7 +1227,7 @@ int load_elf_binary(struct linux_binprm *bprm, struct target_pt_regs *regs,
>      end_data = 0;
>      interp_ex.a_info = 0;
> 
> -    for(i=0;i < elf_ex.e_phnum; i++) {
> +    for(i=0; i < elf_ex.e_phnum; i++) {

While you're at it, please also add white spaces around the "=" in that line.

 Thanks,
  Thomas



  reply	other threads:[~2020-11-04 11:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fc9d7415-a17f-2958-69fd-0b5f54e553a1@huawei.com>
2020-11-04 10:20 ` [PATCH 1/4] bsd-user: space required after semicolon shiliyang
2020-11-04 11:08   ` Thomas Huth [this message]
2020-11-04 11:13     ` Philippe Mathieu-Daudé
2020-11-05  7:21       ` shiliyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28961057-f570-a203-e098-6ec0d5be3f75@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=alex.chen@huawei.com \
    --cc=hunongda@huawei.com \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=shiliyang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).