From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Eric Blake" <eblake@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 09/11] authz: add QAuthZListFile object type for a file access control list
Date: Thu, 6 Dec 2018 18:48:23 +0100 [thread overview]
Message-ID: <28a41967-e327-ed9b-4be7-870ba722718d@redhat.com> (raw)
In-Reply-To: <5a0b8acd-2906-2ee7-1ef2-0035af9af811@redhat.com>
On 12/6/18 6:07 PM, Eric Blake wrote:
> On 12/6/18 9:58 AM, Philippe Mathieu-Daudé wrote:
>
>>>>> "refresh": "yes"
>>>>
>>>> I had to use "refresh": yes (value unquoted) to avoid:
>>>
>>> Do you mean "refresh":true? (bare yes is not valid JSON, but bare true
>>> is the correct way for a JSON bool).
>>
>> I first tried 'true' then was curious and tried 'yes' and it worked
>> too...
>
> Ah, so you're using a python wrapper rather than direct QMP, and
> benefitting from a rather-forgiving parser that turns yes into the
> correct QMP true over the wire to the actual monitor.
I'm not sure I'm using a python wrapper, I use rlwrap following:
https://wiki.qemu.org/Documentation/QMP#Trying_it
Regardless, let's use the correct JSON bool for the documentation.
next prev parent reply other threads:[~2018-12-06 17:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 14:06 [Qemu-devel] [PATCH v7 00/11] Add a standard authorization framework Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 01/11] util: add helper APIs for dealing with inotify in portable manner Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 02/11] qom: don't require user creatable objects to be registered Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 03/11] hw/usb: don't set IN_ISDIR for inotify watch in MTP driver Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 04/11] hw/usb: fix const-ness for string params " Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 05/11] hw/usb: switch MTP to use new inotify APIs Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 06/11] authz: add QAuthZ object as an authorization base class Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 07/11] authz: add QAuthZSimple object type for easy whitelist auth checks Daniel P. Berrangé
2018-12-05 17:13 ` Philippe Mathieu-Daudé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 08/11] authz: add QAuthZList object type for an access control list Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 09/11] authz: add QAuthZListFile object type for a file " Daniel P. Berrangé
2018-12-05 17:23 ` Philippe Mathieu-Daudé
2018-12-05 21:55 ` Eric Blake
2018-12-06 15:58 ` Philippe Mathieu-Daudé
2018-12-06 17:07 ` Eric Blake
2018-12-06 17:48 ` Philippe Mathieu-Daudé [this message]
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 10/11] authz: add QAuthZPAM object type for authorizing using PAM Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 11/11] authz: delete existing ACL implementation Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28a41967-e327-ed9b-4be7-870ba722718d@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).