* [PATCH] x86_64/atomic128-ldst.h: fix arch include guard
@ 2023-06-20 8:39 Frédéric Pétrot
2023-06-20 8:59 ` Richard Henderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Frédéric Pétrot @ 2023-06-20 8:39 UTC (permalink / raw)
To: qemu-trivial, qemu-devel
Cc: richard.henderson, alex.bennee, Frédéric Pétrot
Fix arch name in the define that prevents multiple inclusions.
Signed-off-by: Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
---
host/include/x86_64/host/atomic128-ldst.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/host/include/x86_64/host/atomic128-ldst.h b/host/include/x86_64/host/atomic128-ldst.h
index adc9332f91..d0240d4212 100644
--- a/host/include/x86_64/host/atomic128-ldst.h
+++ b/host/include/x86_64/host/atomic128-ldst.h
@@ -8,8 +8,8 @@
* atomic primitive is meant to provide.
*/
-#ifndef AARCH64_ATOMIC128_LDST_H
-#define AARCH64_ATOMIC128_LDST_H
+#ifndef X86_64_ATOMIC128_LDST_H
+#define X86_64_ATOMIC128_LDST_H
#ifdef CONFIG_INT128_TYPE
#include "host/cpuinfo.h"
@@ -65,4 +65,4 @@ static inline void atomic16_set(Int128 *ptr, Int128 val)
#include "host/include/generic/host/atomic128-ldst.h"
#endif
-#endif /* AARCH64_ATOMIC128_LDST_H */
+#endif /* X86_64_ATOMIC128_LDST_H */
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86_64/atomic128-ldst.h: fix arch include guard
2023-06-20 8:39 [PATCH] x86_64/atomic128-ldst.h: fix arch include guard Frédéric Pétrot
@ 2023-06-20 8:59 ` Richard Henderson
2023-06-20 10:18 ` Philippe Mathieu-Daudé
2023-06-20 10:59 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2023-06-20 8:59 UTC (permalink / raw)
To: Frédéric Pétrot, qemu-trivial, qemu-devel; +Cc: alex.bennee
On 6/20/23 10:39, Frédéric Pétrot wrote:
> Fix arch name in the define that prevents multiple inclusions.
>
> Signed-off-by: Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
> ---
> host/include/x86_64/host/atomic128-ldst.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Whoopsie.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
>
> diff --git a/host/include/x86_64/host/atomic128-ldst.h b/host/include/x86_64/host/atomic128-ldst.h
> index adc9332f91..d0240d4212 100644
> --- a/host/include/x86_64/host/atomic128-ldst.h
> +++ b/host/include/x86_64/host/atomic128-ldst.h
> @@ -8,8 +8,8 @@
> * atomic primitive is meant to provide.
> */
>
> -#ifndef AARCH64_ATOMIC128_LDST_H
> -#define AARCH64_ATOMIC128_LDST_H
> +#ifndef X86_64_ATOMIC128_LDST_H
> +#define X86_64_ATOMIC128_LDST_H
>
> #ifdef CONFIG_INT128_TYPE
> #include "host/cpuinfo.h"
> @@ -65,4 +65,4 @@ static inline void atomic16_set(Int128 *ptr, Int128 val)
> #include "host/include/generic/host/atomic128-ldst.h"
> #endif
>
> -#endif /* AARCH64_ATOMIC128_LDST_H */
> +#endif /* X86_64_ATOMIC128_LDST_H */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86_64/atomic128-ldst.h: fix arch include guard
2023-06-20 8:39 [PATCH] x86_64/atomic128-ldst.h: fix arch include guard Frédéric Pétrot
2023-06-20 8:59 ` Richard Henderson
@ 2023-06-20 10:18 ` Philippe Mathieu-Daudé
2023-06-20 10:59 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-06-20 10:18 UTC (permalink / raw)
To: Frédéric Pétrot, qemu-trivial, qemu-devel
Cc: richard.henderson, alex.bennee
On 20/6/23 10:39, Frédéric Pétrot wrote:
> Fix arch name in the define that prevents multiple inclusions.
>
> Signed-off-by: Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
> ---
> host/include/x86_64/host/atomic128-ldst.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86_64/atomic128-ldst.h: fix arch include guard
2023-06-20 8:39 [PATCH] x86_64/atomic128-ldst.h: fix arch include guard Frédéric Pétrot
2023-06-20 8:59 ` Richard Henderson
2023-06-20 10:18 ` Philippe Mathieu-Daudé
@ 2023-06-20 10:59 ` Richard Henderson
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2023-06-20 10:59 UTC (permalink / raw)
To: Frédéric Pétrot, qemu-trivial, qemu-devel; +Cc: alex.bennee
On 6/20/23 10:39, Frédéric Pétrot wrote:
> Fix arch name in the define that prevents multiple inclusions.
>
> Signed-off-by: Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
> ---
> host/include/x86_64/host/atomic128-ldst.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/host/include/x86_64/host/atomic128-ldst.h b/host/include/x86_64/host/atomic128-ldst.h
> index adc9332f91..d0240d4212 100644
> --- a/host/include/x86_64/host/atomic128-ldst.h
> +++ b/host/include/x86_64/host/atomic128-ldst.h
> @@ -8,8 +8,8 @@
> * atomic primitive is meant to provide.
> */
>
> -#ifndef AARCH64_ATOMIC128_LDST_H
> -#define AARCH64_ATOMIC128_LDST_H
> +#ifndef X86_64_ATOMIC128_LDST_H
> +#define X86_64_ATOMIC128_LDST_H
>
> #ifdef CONFIG_INT128_TYPE
> #include "host/cpuinfo.h"
> @@ -65,4 +65,4 @@ static inline void atomic16_set(Int128 *ptr, Int128 val)
> #include "host/include/generic/host/atomic128-ldst.h"
> #endif
>
> -#endif /* AARCH64_ATOMIC128_LDST_H */
> +#endif /* X86_64_ATOMIC128_LDST_H */
Actually, I recently merged a fix for this: 8a2bd747877.
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-20 11:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-20 8:39 [PATCH] x86_64/atomic128-ldst.h: fix arch include guard Frédéric Pétrot
2023-06-20 8:59 ` Richard Henderson
2023-06-20 10:18 ` Philippe Mathieu-Daudé
2023-06-20 10:59 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).