qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: linzhecheng <linzhecheng@huawei.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com, wangxinxin.wang@huawei.com, liujunjie23@huawei.com
Subject: Re: [Qemu-devel] [PATCH v2] vhost-user: delete net client if necessary
Date: Fri, 15 Jun 2018 10:35:37 +0800	[thread overview]
Message-ID: <28e11eba-366e-37a4-710f-5afb37fb0c96@redhat.com> (raw)
In-Reply-To: <20180612022445.5192-1-linzhecheng@huawei.com>



On 2018年06月12日 10:24, linzhecheng wrote:
> As qemu_new_net_client create new ncs but error happens later,
> ncs will be left in global net_clients list and we can't use them any
> more, so we need to cleanup them.
>
> Signed-off-by: linzhecheng <linzhecheng@huawei.com>
>
> diff --git a/net/vhost-user.c b/net/vhost-user.c
> index 608b837175..a39f9c9974 100644
> --- a/net/vhost-user.c
> +++ b/net/vhost-user.c
> @@ -345,6 +345,9 @@ err:
>               s->vhost_user = NULL;
>           }
>       }
> +    if (nc0) {
> +        qemu_del_net_client(nc0);
> +    }
>   
>       return -1;
>   }

Applied and queued for -stable.

Please cc stable next time.

Btw, do we have similar issues for tap?

Thanks

      reply	other threads:[~2018-06-15  2:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12  2:24 [Qemu-devel] [PATCH v2] vhost-user: delete net client if necessary linzhecheng
2018-06-15  2:35 ` Jason Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28e11eba-366e-37a4-710f-5afb37fb0c96@redhat.com \
    --to=jasowang@redhat.com \
    --cc=linzhecheng@huawei.com \
    --cc=liujunjie23@huawei.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wangxinxin.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).