From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v4 01/27] tcg: Fix tcg_reg_alloc_dup*
Date: Mon, 19 Dec 2022 10:17:39 -0800 [thread overview]
Message-ID: <28e7c49a-88a9-0268-9c21-859a1f5b643f@linaro.org> (raw)
In-Reply-To: <87y1r3jsr5.fsf@linaro.org>
On 12/19/22 07:49, Alex Bennée wrote:
>
> Richard Henderson <richard.henderson@linaro.org> writes:
>
>> The assignment to mem_coherent should be done with any
>> modification, not simply with a newly allocated register.
>
> What exactly does mem_coherent mean in this case? Is it that our
> register store is potentially out of sync with live values in temp regs
> or that we have memory loads and stores in flight?
>
> I think it would be useful to add a doc patch for TCGTemp do specify
> what the various fields mean. It would certainly help reviewers that
> don't have it committed to memory ;-)
>
mem_coherent means that the register value and the memory value are the same, so that if
we must release the register we do not need to save the value back to memory.
r~
next prev parent reply other threads:[~2022-12-19 18:19 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 21:25 [PATCH v4 00/27] tcg misc patches Richard Henderson
2022-12-13 21:25 ` [PATCH v4 01/27] tcg: Fix tcg_reg_alloc_dup* Richard Henderson
2022-12-19 15:49 ` Alex Bennée
2022-12-19 18:17 ` Richard Henderson [this message]
2022-12-13 21:25 ` [PATCH v4 02/27] tcg: Centralize updates to reg_to_temp Richard Henderson
2022-12-19 16:17 ` Alex Bennée
2022-12-13 21:25 ` [PATCH v4 03/27] tcg: Remove check_regs Richard Henderson
2022-12-19 16:17 ` Alex Bennée
2022-12-13 21:25 ` [PATCH v4 04/27] tcg: Introduce paired register allocation Richard Henderson
2022-12-19 22:09 ` Philippe Mathieu-Daudé
2022-12-19 22:09 ` [PATCH v4 04a/27] tcg: Massage process_op_defs() Philippe Mathieu-Daudé
2022-12-19 22:09 ` [PATCH v4 04b/27] tcg: Massage tcg_reg_alloc_op() Philippe Mathieu-Daudé
2022-12-19 22:09 ` [PATCH v4 04c/27] tcg: Introduce paired register allocation Philippe Mathieu-Daudé
2022-12-13 21:25 ` [PATCH v4 05/27] accel/tcg: Set cflags_next_tb in cpu_common_initfn Richard Henderson
2022-12-19 17:19 ` Alex Bennée
2022-12-13 21:25 ` [PATCH v4 06/27] target/sparc: Avoid TCGV_{LOW,HIGH} Richard Henderson
2022-12-18 21:35 ` Philippe Mathieu-Daudé
2022-12-13 21:25 ` [PATCH v4 07/27] tcg: Move TCG_{LOW,HIGH} to tcg-internal.h Richard Henderson
2022-12-13 21:25 ` [PATCH v4 08/27] tcg: Add temp_subindex to TCGTemp Richard Henderson
2022-12-13 21:25 ` [PATCH v4 09/27] tcg: Simplify calls to temp_sync vs mem_coherent Richard Henderson
2022-12-18 21:38 ` Philippe Mathieu-Daudé
2022-12-13 21:25 ` [PATCH v4 10/27] tcg: Allocate TCGTemp pairs in host memory order Richard Henderson
2022-12-13 21:25 ` [PATCH v4 11/27] tcg: Move TCG_TYPE_COUNT outside enum Richard Henderson
2022-12-13 21:25 ` [PATCH v4 12/27] tcg: Introduce tcg_type_size Richard Henderson
2022-12-13 21:25 ` [PATCH v4 13/27] tcg: Introduce TCGCallReturnKind and TCGCallArgumentKind Richard Henderson
2022-12-19 17:23 ` Alex Bennée
2022-12-13 21:25 ` [PATCH v4 14/27] tcg: Replace TCG_TARGET_CALL_ALIGN_ARGS with TCG_TARGET_CALL_ARG_I64 Richard Henderson
2022-12-13 21:25 ` [PATCH v4 15/27] tcg: Replace TCG_TARGET_EXTEND_ARGS with TCG_TARGET_CALL_ARG_I32 Richard Henderson
2022-12-13 21:25 ` [PATCH v4 16/27] tcg: Use TCG_CALL_ARG_EVEN for TCI special case Richard Henderson
2022-12-13 21:25 ` [PATCH v4 17/27] accel/tcg/plugin: Don't search for the function pointer index Richard Henderson
2022-12-18 21:25 ` Philippe Mathieu-Daudé
2022-12-13 21:25 ` [PATCH v4 18/27] accel/tcg/plugin: Avoid duplicate copy in copy_call Richard Henderson
2022-12-19 17:23 ` Alex Bennée
2022-12-13 21:25 ` [PATCH v4 19/27] accel/tcg/plugin: Use copy_op in append_{udata, mem}_cb Richard Henderson
2022-12-19 17:24 ` [PATCH v4 19/27] accel/tcg/plugin: Use copy_op in append_{udata,mem}_cb Alex Bennée
2022-12-13 21:25 ` [PATCH v4 20/27] tcg: Vary the allocation size for TCGOp Richard Henderson
2022-12-18 21:18 ` Philippe Mathieu-Daudé
2022-12-18 21:18 ` [PATCH v4 20a/27] tcg: Pass number of arguments to tcg_emit_op() / tcg_op_insert_*() Philippe Mathieu-Daudé
2022-12-18 21:39 ` Philippe Mathieu-Daudé
2022-12-18 21:18 ` [PATCH v4 20b/27] tcg: Vary the allocation size for TCGOp Philippe Mathieu-Daudé
2022-12-18 21:49 ` Philippe Mathieu-Daudé
2022-12-18 22:44 ` Richard Henderson
2022-12-19 7:16 ` Philippe Mathieu-Daudé
2022-12-19 17:28 ` [PATCH v4 20/27] " Alex Bennée
2022-12-13 21:25 ` [PATCH v4 21/27] tcg: Use output_pref wrapper function Richard Henderson
2022-12-13 21:25 ` [PATCH v4 22/27] tcg: Reorg function calls Richard Henderson
2022-12-13 21:25 ` [PATCH v4 23/27] tcg: Convert typecode_to_ffi from array to function Richard Henderson
2022-12-13 21:25 ` [PATCH v4 24/27] tcg: Factor init_ffi_layouts() out of tcg_context_init() Richard Henderson
2022-12-13 21:25 ` [PATCH v4 25/27] tcg: Move ffi_cif pointer into TCGHelperInfo Richard Henderson
2022-12-13 21:25 ` [PATCH v4 26/27] tcg/aarch64: Merge tcg_out_callr into tcg_out_call Richard Henderson
2022-12-18 21:21 ` Philippe Mathieu-Daudé
2022-12-13 21:25 ` [PATCH v4 27/27] tcg: Add TCGHelperInfo argument to tcg_out_call Richard Henderson
2022-12-18 17:23 ` [PATCH v4 00/27] tcg misc patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28e7c49a-88a9-0268-9c21-859a1f5b643f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).