From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, philmd@redhat.com,
ehabkost@redhat.com, crosa@redhat.com
Subject: Re: [PATCH v2 3/4] qapi: Use super() now we have Python 3
Date: Wed, 4 Mar 2020 15:30:07 -0500 [thread overview]
Message-ID: <28ec8c76-c779-c279-f71a-a8751c6a081a@redhat.com> (raw)
In-Reply-To: <20200304155932.20452-4-armbru@redhat.com>
On 3/4/20 10:59 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi/commands.py | 4 +--
> scripts/qapi/error.py | 4 +--
> scripts/qapi/events.py | 4 +--
> scripts/qapi/gen.py | 10 ++++----
> scripts/qapi/introspect.py | 4 +--
> scripts/qapi/parser.py | 2 +-
> scripts/qapi/schema.py | 51 +++++++++++++++++++-------------------
> scripts/qapi/types.py | 4 +--
> scripts/qapi/visit.py | 4 +--
> 9 files changed, 43 insertions(+), 44 deletions(-)
>
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2020-03-04 20:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 15:59 [PATCH v2 0/4] qapi: Bye-bye Python 2 Markus Armbruster
2020-03-04 15:59 ` [PATCH v2 1/4] qapi: Inheriting from object is pointless with Python 3, drop Markus Armbruster
2020-03-04 20:25 ` John Snow
2020-03-04 15:59 ` [PATCH v2 2/4] qapi: Drop conditionals for Python 2 Markus Armbruster
2020-03-04 20:26 ` John Snow
2020-03-04 15:59 ` [PATCH v2 3/4] qapi: Use super() now we have Python 3 Markus Armbruster
2020-03-04 20:30 ` John Snow [this message]
2020-03-04 15:59 ` [PATCH v2 4/4] qapi: Brush off some (py)lint Markus Armbruster
2020-03-04 20:33 ` John Snow
2020-03-05 5:56 ` Markus Armbruster
2020-03-05 18:09 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28ec8c76-c779-c279-f71a-a8751c6a081a@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).