From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E2CEC433E0 for ; Mon, 1 Mar 2021 08:42:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF40864DE3 for ; Mon, 1 Mar 2021 08:42:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF40864DE3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGe8k-0002CB-32 for qemu-devel@archiver.kernel.org; Mon, 01 Mar 2021 03:42:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGe7T-0001h9-IJ for qemu-devel@nongnu.org; Mon, 01 Mar 2021 03:41:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:36316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGe7R-0000xW-IZ for qemu-devel@nongnu.org; Mon, 01 Mar 2021 03:41:35 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 13A37AA4F; Mon, 1 Mar 2021 08:41:31 +0000 (UTC) Subject: Re: [PATCH v25 14/20] i386: separate fpu_helper into user and sysemu parts To: Richard Henderson , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Eduardo Habkost , Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210226175143.22388-1-cfontana@suse.de> <20210226175143.22388-15-cfontana@suse.de> From: Claudio Fontana Message-ID: <28f1e68d-cbf7-dc06-e352-fe0f218b0dea@suse.de> Date: Mon, 1 Mar 2021 09:41:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Roman Bolshakov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/26/21 7:42 PM, Richard Henderson wrote: > On 2/26/21 9:51 AM, Claudio Fontana wrote: >> +/* fpu_helper.c */ >> + >> +void do_fsave(CPUX86State *env, target_ulong ptr, int data32, uintptr_t ra); >> +void do_frstor(CPUX86State *env, target_ulong ptr, int data32, uintptr_t ra); >> +void do_fxsave(CPUX86State *env, target_ulong ptr, uintptr_t ra); >> +void do_fxrstor(CPUX86State *env, target_ulong ptr, uintptr_t ra); > > Is this really worth it? No, probably not. Will respin without these parts, and leaving the small ifdefs in the global tcg/fpu_helper.c Thanks, Claudio > It means that we unnecessarily expose these functions > in system mode, where they are still not safe. > > I had thought about doing something like > > #ifdef CONFIG_USER_ONLY > #define SYSEMU_STATIC > #else > #define SYSEMU_STATIC static > #endif > > SYSEMU_STATIC void > cpu_x86_fsave(...) > { > ... > } > > void helper_fsave(...) > { > cpu_x86_fsave(..., GETPC()); > } > > but I thought the existing example of "do_" functions within that file to be > compelling. I think small sections of this CONFIG within a file should be > fine, especially where it interacts with other functions like this. > > I guess either way, > Reviewed-by: Richard Henderson > > > r~ >